linux-kernel - Re: [PATCH v3] wifi: mwifiex: Convert to use jiffies macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zswjc9GjE9V1C7VT@gaggiata.pivistrello.it>
Date: Mon, 26 Aug 2024 08:40:51 +0200
From: Francesco Dolcini <francesco@...cini.it>
To: 陈玉凡 <chenyufan@...o.com>
Cc: Brian Norris <briannorris@...omium.org>,
	Francesco Dolcini <francesco@...cini.it>,
	Kalle Valo <kvalo@...nel.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"opensource.kernel" <opensource.kernel@...o.com>
Subject: Re: [PATCH v3] wifi: mwifiex: Convert to use jiffies macro

On Mon, Aug 26, 2024 at 03:18:28AM +0000, 陈玉凡 wrote:
> 在 2024/8/24 1:01, Brian Norris 写道:
> > On Fri, Aug 23, 2024 at 03:03:19PM +0800, Chen Yufan wrote:
> >> Use time_after macro instead of using
> >> jiffies directly to handle wraparound.
> >> The modifications made compared to the previous version are as follows:
> >> 1. change the type of mwifiex_auto_tdls_peer::rssi_jiffies to
> >> unsigned long.
> >>
> >> Signed-off-by: Chen Yufan <chenyufan@...o.com>
> > Changelog questions aside, this looks fine to me:
> >
> > Acked-by: Brian Norris <briannorris@...omium.org>
> 
> Thanks, I will pay attention to this question next time.

You should just send a v4 with this addressed and add the acked-by from Brian
while doing it.

Francesco