linux-kernel - Re: [PATCH md-6.12 05/41] md/md-bitmap: add 'sync_size' into struct md_bitmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fc5f783f-2d2b-4066-2a46-c4ed761e661b@huaweicloud.com>
Date: Mon, 26 Aug 2024 09:38:47 +0800
From: Yu Kuai <yukuai1@...weicloud.com>
To: kernel test robot <lkp@...el.com>, Yu Kuai <yukuai1@...weicloud.com>,
 song@...nel.org, mariusz.tkaczyk@...ux.intel.com, l@...enly.org,
 xni@...hat.com
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
 linux-raid@...r.kernel.org, yi.zhang@...wei.com, yangerkun@...wei.com,
 "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH md-6.12 05/41] md/md-bitmap: add 'sync_size' into struct
 md_bitmap_stats

Hi,

在 2024/08/23 6:07, kernel test robot 写道:
> Hi Yu,
> 
> kernel test robot noticed the following build warnings:
> 
> [auto build test WARNING on device-mapper-dm/for-next]
> [also build test WARNING on linus/master v6.11-rc4 next-20240822]
> [cannot apply to song-md/md-next]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Yu-Kuai/md-raid1-use-md_bitmap_wait_behind_writes-in-raid1_read_request/20240822-110233
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git for-next
> patch link:    https://lore.kernel.org/r/20240822024718.2158259-6-yukuai1%40huaweicloud.com
> patch subject: [PATCH md-6.12 05/41] md/md-bitmap: add 'sync_size' into struct md_bitmap_stats
> config: x86_64-randconfig-121-20240822 (https://download.01.org/0day-ci/archive/20240823/202408230544.w18wb47U-lkp@intel.com/config)
> compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240823/202408230544.w18wb47U-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202408230544.w18wb47U-lkp@intel.com/
> 
> sparse warnings: (new ones prefixed by >>)
>>> drivers/md/md-bitmap.c:2106:26: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned long sync_size @@     got restricted __le64 [usertype] sync_size @@
>     drivers/md/md-bitmap.c:2106:26: sparse:     expected unsigned long sync_size
>     drivers/md/md-bitmap.c:2106:26: sparse:     got restricted __le64 [usertype] sync_size

So this is actually the old code behavior. I'll fix this. :)

Thanks,
Kuai

>     drivers/md/md-bitmap.c: note: in included file (through include/linux/mmzone.h, include/linux/gfp.h, include/linux/xarray.h, ...):
>     include/linux/page-flags.h:235:46: sparse: sparse: self-comparison always evaluates to false
>     include/linux/page-flags.h:235:46: sparse: sparse: self-comparison always evaluates to false
> 
> vim +2106 drivers/md/md-bitmap.c
> 
>    2096	
>    2097	int md_bitmap_get_stats(struct bitmap *bitmap, struct md_bitmap_stats *stats)
>    2098	{
>    2099		struct bitmap_counts *counts;
>    2100		bitmap_super_t *sb;
>    2101	
>    2102		if (!bitmap)
>    2103			return -ENOENT;
>    2104	
>    2105		sb = kmap_local_page(bitmap->storage.sb_page);
>> 2106		stats->sync_size = sb->sync_size;
>    2107		kunmap_local(sb);
>    2108	
>    2109		counts = &bitmap->counts;
>    2110		stats->missing_pages = counts->missing_pages;
>    2111		stats->pages = counts->pages;
>    2112	
>    2113		stats->events_cleared = bitmap->events_cleared;
>    2114		stats->file = bitmap->storage.file;
>    2115	
>    2116		return 0;
>    2117	}
>    2118	EXPORT_SYMBOL_GPL(md_bitmap_get_stats);
>    2119	
>