linux-kernel - Re: [PATCH v2 14/17] selftests: vdso: Make test_vdso_getrandom look for the right vDSO function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <07ec9ebb-eab6-4350-9353-a58ebb06000e@cs-soprasteria.com>
Date: Mon, 26 Aug 2024 07:35:38 +0000
From: LEROY Christophe <christophe.leroy2@...soprasteria.com>
To: "Jason A. Donenfeld" <Jason@...c4.com>
CC: Michael Ellerman <mpe@...erman.id.au>, Nicholas Piggin
	<npiggin@...il.com>, Naveen N Rao <naveen@...nel.org>, Andy Lutomirski
	<luto@...nel.org>, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar
	<mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, Dave Hansen
	<dave.hansen@...ux.intel.com>, "x86@...nel.org" <x86@...nel.org>, "H. Peter
 Anvin" <hpa@...or.com>, Theodore Ts'o <tytso@....edu>, Arnd Bergmann
	<arnd@...db.de>, Andrew Morton <akpm@...ux-foundation.org>, Steven Rostedt
	<rostedt@...dmis.org>, Masami Hiramatsu <mhiramat@...nel.org>, Mathieu
 Desnoyers <mathieu.desnoyers@...icios.com>, Vincenzo Frascino
	<vincenzo.frascino@....com>, Shuah Khan <shuah@...nel.org>,
	"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	"linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	"linux-trace-kernel@...r.kernel.org" <linux-trace-kernel@...r.kernel.org>,
	"linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>
Subject: Re: [PATCH v2 14/17] selftests: vdso: Make test_vdso_getrandom look
 for the right vDSO function



Le 26/08/2024 à 09:28, Jason A. Donenfeld a écrit :
> On Thu, Aug 22, 2024 at 09:13:22AM +0200, Christophe Leroy wrote:
>> Don't hard-code x86 specific names, use vdso_config definitions
>> to find the correct function matching the architecture.
>>
>> Add random VDSO function names in names[][]. Remove the #ifdef
>> CONFIG_VDSO32, having the name there all the time is harmless
>> and guaranties a steady index for following strings.
> 
> This is indeed the right way of doing it. Thanks. I'll take this now,
> though with one small fixup:
> 
>> +	const char *version = versions[VDSO_VERSION];
>> +	const char **name = (const char **)&names[VDSO_NAMES];
> 
> I'll just do:
> 
>          const char *name = names[VDSO_NAMES][6];
> 
> Instead of referring to name[6] everywhere after. Seems more straight
> forward.

Yes you are right that's more straight forward when using only one of 
the names.
I copy-pasted it from the gettimeofday test which uses several names 
from the table.

Christophe