linux-kernel - Re: [PATCH v1] pinctrl: nomadik: Use kmemdup_array instead of kmemdup for multiple allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <319dc757-2182-431a-8e60-bc37f640971a@vivo.com>
Date: Mon, 26 Aug 2024 07:42:18 +0000
From: 于佼良 <yujiaoliang@...o.com>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
CC: Linus Walleij <linus.walleij@...aro.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-gpio@...r.kernel.org"
	<linux-gpio@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, opensource.kernel
	<opensource.kernel@...o.com>
Subject: Re: [PATCH v1] pinctrl: nomadik: Use kmemdup_array instead of kmemdup
 for multiple allocation

在 2024/8/23 23:27, Andy Shevchenko 写道:
> [Some people who received this message don't often get email from andriy.shevchenko@...el.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> On Wed, Aug 21, 2024 at 02:49:58PM +0800, Yu Jiaoliang wrote:
>> Let the kememdup_array() take care about multiplication and possible
> kmemdup_array()
>
>> overflows.
> ...
>
>> +     dup_configs = kmemdup_array(configs, num_configs, sizeof(*dup_configs),
>> +                                 GFP_KERNEL);
> I would even make this a single line.
>
> ...
>
>> +     dup_configs = kmemdup_array(configs, num_configs, sizeof(*dup_configs),
>> +                                 GFP_KERNEL);
>
> Ditto.
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
Hi Andy,

I have reformatted the code and submitted patch v2. Thank you.

Best Regards,

Yu