linux-kernel - Re: [PATCH v2 16/17] selftests: vdso: Make VDSO function call more generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2d4e5b66-3aee-40d9-acd3-394e4100ecf5@cs-soprasteria.com>
Date: Mon, 26 Aug 2024 07:48:33 +0000
From: LEROY Christophe <christophe.leroy2@...soprasteria.com>
To: "Jason A. Donenfeld" <Jason@...c4.com>, LEROY Christophe
	<christophe.leroy2@...soprasteria.com>
CC: Michael Ellerman <mpe@...erman.id.au>, Nicholas Piggin
	<npiggin@...il.com>, Naveen N Rao <naveen@...nel.org>, Andy Lutomirski
	<luto@...nel.org>, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar
	<mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, Dave Hansen
	<dave.hansen@...ux.intel.com>, "x86@...nel.org" <x86@...nel.org>, "H. Peter
 Anvin" <hpa@...or.com>, Theodore Ts'o <tytso@....edu>, Arnd Bergmann
	<arnd@...db.de>, Andrew Morton <akpm@...ux-foundation.org>, Steven Rostedt
	<rostedt@...dmis.org>, Masami Hiramatsu <mhiramat@...nel.org>, Mathieu
 Desnoyers <mathieu.desnoyers@...icios.com>, Vincenzo Frascino
	<vincenzo.frascino@....com>, Shuah Khan <shuah@...nel.org>,
	"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	"linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	"linux-trace-kernel@...r.kernel.org" <linux-trace-kernel@...r.kernel.org>,
	"linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>
Subject: Re: [PATCH v2 16/17] selftests: vdso: Make VDSO function call more
 generic



Le 26/08/2024 à 09:37, Jason A. Donenfeld a écrit :
> On Thu, Aug 22, 2024 at 09:13:24AM +0200, Christophe Leroy wrote:
>> On powerpc, a call to a VDSO function is not a standard C function
>> call. Unlike x86 that returns a negated error code in case of an
>> error, powerpc sets CR[SO] and returns the error code as a
>> positive value.
>>
>> So use a macro called VDSO_CALL() which takes a pointer to the
>> function to call, the number of arguments and the arguments.
>   
> You'll probably want to move to VDSO_CALL() for the whole test suite,
> not just the getrandom one, right?

Yes indeed, the following needs it as well:

vdso_test_abi.c
vdso_test_getcpu.c
vdso_test_gettimeofday.c
vdso_test_correctness.c

Christophe