[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240826100539.7f93f8b9@xps-13>
Date: Mon, 26 Aug 2024 10:05:39 +0200
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Frank Li <Frank.li@....com>
Cc: Alexandre Belloni <alexandre.belloni@...tlin.com>, Boris Brezillon
<boris.brezillon@...labora.com>, Parshuram Thombare <pthombar@...ence.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Boris Brezillon
<bbrezillon@...nel.org>, Arnd Bergmann <arnd@...db.de>, Conor Culhane
<conor.culhane@...vaco.com>, linux-i3c@...ts.infradead.org,
linux-kernel@...r.kernel.org, imx@...ts.linux.dev
Subject: Re: [PATCH v3 02/11] i3c: master: Replace hard code 2 with macro
I3C_ADDR_SLOT_BITS
Hi Frank,
Frank.li@....com wrote on Fri, 23 Aug 2024 13:57:31 -0400:
> On Fri, Aug 23, 2024 at 05:55:02PM +0200, Miquel Raynal wrote:
> > Hi Frank,
> >
> > Frank.Li@....com wrote on Mon, 19 Aug 2024 12:01:56 -0400:
> >
> > > Replace the hardcoded value 2, which indicates 2 bits for I3C address
> > > status, with the predefined macro I3C_ADDR_SLOT_BITS.
> >
> > I'm fine with the idea but I don't understand the macro name. You're
> > talking about status bits and yet the macro is named addr_slot?
> >
>
> How about I3C_ADDR_SLOT_STATUS_BITS ?
>
> > > Improve maintainability and extensibility of the code.
I'm a bit flaky on this concept, but let's try that. Perhaps with all
the changes requested (esp. rephrasing) it might become clearer in next
version.
Thanks,
Miquèl
Powered by blists - more mailing lists