[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8e14d43b-598b-4aef-9c22-84122e17a77e@kernel.org>
Date: Mon, 26 Aug 2024 10:08:37 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Junhao Xie <bigfoot@...ssfun.cn>
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Heiko Stuebner <heiko@...ech.de>,
Jonas Karlman <jonas@...boo.se>, Chukun Pan <amadeus@....edu.cn>,
FUKAUMI Naoki <naoki@...xa.com>, Dragan Simic <dsimic@...jaro.org>,
linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: rockchip: add dts for LCKFB Taishan Pi
RK3566
On 26/08/2024 09:46, Junhao Xie wrote:
> On 2024/8/26 14:06, Krzysztof Kozlowski wrote:
>> On Mon, Aug 26, 2024 at 12:44:13PM +0800, Junhao Xie wrote:
>>> Add dts for LCKFB Taishan Pi.
>>>
>
> [...]
>
>>
>>> + dc_12v: dc-12v {
>>
>> Use some reasonable prefix or suffix (regulator) for all regulator
>> nodes. Or even: use name for all fixed regulators which matches current
>> format recommendation: 'regulator-[0-9]v[0-9]'
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml?h=v6.11-rc1#n46
>>
>
> Thanks, I will rename it to dc-12v-regulator
Well, this makes ordering tricky and is not the proposed policy, but
sure... I gave you reference hoping you will read it.
Best regards,
Krzysztof
Powered by blists - more mailing lists