linux-kernel - Re: [PATCH v3 3/3] LoongArch: Update dts to support Loongson UART driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51f564ea-9507-40b4-a943-23bdd330e6d6@kernel.org>
Date: Mon, 26 Aug 2024 10:18:21 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: 郑豪威 <zhenghaowei@...ngson.cn>
Cc: gregkh@...uxfoundation.org, jirislaby@...nel.org, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, chenhuacai@...nel.org,
 kernel@...0n.name, p.zabel@...gutronix.de, linux-serial@...r.kernel.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 loongarch@...ts.linux.dev
Subject: Re: [PATCH v3 3/3] LoongArch: Update dts to support Loongson UART
 driver.

On 26/08/2024 08:54, 郑豪威 wrote:
> 
> 在 2024/8/26 14:00, Krzysztof Kozlowski 写道:
>> On Mon, Aug 26, 2024 at 10:47:05AM +0800,zhenghaowei@...ngson.cn wrote:
>>> From: Haowei Zheng<zhenghaowei@...ngson.cn>
>>>
>>> Change to use the Loongson UART driver for Loongson-2K2000,
>>> Loongson-2K1000 and Loongson-2K0500.
>> Why?
>>
>> That's what commit msg should explain.  This is not bisectable and
>> breaks users without any reasonable need/explanation.
>>
>> Best regards,
>> Krzysztof
> 
> I got it, and I will provide detailed explanations like this:
> 
> We have provided separate UART drivers for ls2k0500,  ls2k1000, and
> 
> ls2k2000, which solves the issue of the full-featured serial port being
> 
> unusable. Additionally, we have implemented fractional division
> 
> functionality for ls2k2000.

You still break the users. Explain the problem you are fixing. NAK.

Best regards,
Krzysztof