linux-kernel - Re: [PATCH] amba: make amba

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f5fc71f8-5b14-4cb6-b0ae-cc4ef333526b@linux.dev>
Date: Mon, 26 Aug 2024 16:20:33 +0800
From: Kunwu Chan <kunwu.chan@...ux.dev>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: linux@...linux.org.uk, krzk@...nel.org, andi.shyti@...nel.org,
 robh@...nel.org, gregkh@...uxfoundation.org, suzuki.poulose@....com,
 rmk+kernel@...linux.org.uk, linux-kernel@...r.kernel.org,
 Kunwu Chan <chentao@...inos.cn>
Subject: Re: [PATCH] amba: make amba_bustype constant

Thanks for the reply.
On 2024/8/23 21:48, Andy Shevchenko wrote:
> On Fri, Aug 23, 2024 at 02:42:03PM +0800, Kunwu Chan wrote:
>> From: Kunwu Chan <chentao@...inos.cn>
>>
>> Since commit d492cc2573a0 ("driver core: device.h: make struct
>> bus_type a const *"), the driver core can properly handle constant
>> struct bus_type, move the amba_bustype variable to be a constant
>> structure as well, placing it into read-only memory which can not be
>> modified at runtime.
> ...
>
>> -extern struct bus_type amba_bustype;
>> +extern const struct bus_type amba_bustype;
> Can we actually hide this from the outside, i.e. make it static in the C file,
> and introduce the dev_is_amba() helper instead?
Sure, i've find the patch  series 
(https://lore.kernel.org/all/20240528102708.1451343-2-andy.shevchenko@gmail.com/)
> P.S. You may look at the PNP bus case (some of the latest patches there).
>
I'll change it as PNP bus in v2.

-- 
Thanks,
   Kunwu.Chan