linux-kernel - Re: [PATCH] ufs: Remove redundant inode number check from ufs_nfs_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202408261605.ARxTA9jX-lkp@intel.com>
Date: Mon, 26 Aug 2024 17:12:19 +0800
From: kernel test robot <lkp@...el.com>
To: sergii.boryshchenko@...ballogic.com, dushistov@...l.ru
Cc: oe-kbuild-all@...ts.linux.dev, linux-nfs@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	Sergii Boryshchenko <sergii.boryshchenko@...ballogic.com>
Subject: Re: [PATCH] ufs: Remove redundant inode number check from
 ufs_nfs_get_inode

Hi,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on viro-vfs/for-next v6.11-rc5 next-20240823]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/sergii-boryshchenko-globallogic-com/ufs-Remove-redundant-inode-number-check-from-ufs_nfs_get_inode/20240826-120030
base:   linus/master
patch link:    https://lore.kernel.org/r/20240822142610.129668-1-sergii.boryshchenko%40globallogic.com
patch subject: [PATCH] ufs: Remove redundant inode number check from ufs_nfs_get_inode
config: arc-randconfig-001-20240826 (https://download.01.org/0day-ci/archive/20240826/202408261605.ARxTA9jX-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240826/202408261605.ARxTA9jX-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408261605.ARxTA9jX-lkp@intel.com/

All warnings (new ones prefixed by >>):

   fs/ufs/super.c: In function 'ufs_nfs_get_inode':
>> fs/ufs/super.c:101:37: warning: unused variable 'uspi' [-Wunused-variable]
     101 |         struct ufs_sb_private_info *uspi = UFS_SB(sb)->s_uspi;
         |                                     ^~~~


vim +/uspi +101 fs/ufs/super.c

^1da177e4c3f41 Linus Torvalds  2005-04-16   98  
f3e2a520f5fb1a Alexey Dobriyan 2009-12-15   99  static struct inode *ufs_nfs_get_inode(struct super_block *sb, u64 ino, u32 generation)
f3e2a520f5fb1a Alexey Dobriyan 2009-12-15  100  {
f3e2a520f5fb1a Alexey Dobriyan 2009-12-15 @101  	struct ufs_sb_private_info *uspi = UFS_SB(sb)->s_uspi;
f3e2a520f5fb1a Alexey Dobriyan 2009-12-15  102  	struct inode *inode;
f3e2a520f5fb1a Alexey Dobriyan 2009-12-15  103  
f3e2a520f5fb1a Alexey Dobriyan 2009-12-15  104  	inode = ufs_iget(sb, ino);
f3e2a520f5fb1a Alexey Dobriyan 2009-12-15  105  	if (IS_ERR(inode))
f3e2a520f5fb1a Alexey Dobriyan 2009-12-15  106  		return ERR_CAST(inode);
f3e2a520f5fb1a Alexey Dobriyan 2009-12-15  107  	if (generation && inode->i_generation != generation) {
f3e2a520f5fb1a Alexey Dobriyan 2009-12-15  108  		iput(inode);
f3e2a520f5fb1a Alexey Dobriyan 2009-12-15  109  		return ERR_PTR(-ESTALE);
f3e2a520f5fb1a Alexey Dobriyan 2009-12-15  110  	}
f3e2a520f5fb1a Alexey Dobriyan 2009-12-15  111  	return inode;
f3e2a520f5fb1a Alexey Dobriyan 2009-12-15  112  }
f3e2a520f5fb1a Alexey Dobriyan 2009-12-15  113  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki