linux-kernel - RE: [EXT] [PATCH 10/31] wifi: mwifiex: fix indention

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PA4PR04MB96386A441739C4D35683512FD18B2@PA4PR04MB9638.eurprd04.prod.outlook.com>
Date: Mon, 26 Aug 2024 09:48:38 +0000
From: David Lin <yu-hao.lin@....com>
To: Sascha Hauer <s.hauer@...gutronix.de>
CC: Brian Norris <briannorris@...omium.org>, Francesco Dolcini
	<francesco@...cini.it>, Kalle Valo <kvalo@...nel.org>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel@...gutronix.de" <kernel@...gutronix.de>, Pete Hsieh
	<tsung-hsien.hsieh@....com>
Subject: RE: [EXT] [PATCH 10/31] wifi: mwifiex: fix indention

> From: Sascha Hauer <s.hauer@...gutronix.de>
> Sent: Monday, August 26, 2024 5:37 PM
> To: David Lin <yu-hao.lin@....com>
> Cc: Brian Norris <briannorris@...omium.org>; Francesco Dolcini
> <francesco@...cini.it>; Kalle Valo <kvalo@...nel.org>;
> linux-wireless@...r.kernel.org; linux-kernel@...r.kernel.org;
> kernel@...gutronix.de
> Subject: Re: [EXT] [PATCH 10/31] wifi: mwifiex: fix indention
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> On Thu, Aug 22, 2024 at 09:36:29AM +0000, David Lin wrote:
> > > From: Sascha Hauer <s.hauer@...gutronix.de>
> > > Sent: Tuesday, August 20, 2024 7:56 PM
> > > To: Brian Norris <briannorris@...omium.org>; Francesco Dolcini
> > > <francesco@...cini.it>; Kalle Valo <kvalo@...nel.org>
> > > Cc: linux-wireless@...r.kernel.org; linux-kernel@...r.kernel.org;
> > > kernel@...gutronix.de; Sascha Hauer <s.hauer@...gutronix.de>
> > > Subject: [EXT] [PATCH 10/31] wifi: mwifiex: fix indention
> > >
> > > Align multiline if() under the opening brace.
> > >
> > > Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>
> > > ---
> > >  drivers/net/wireless/marvell/mwifiex/wmm.c | 12 ++++++------
> > >  1 file changed, 6 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/drivers/net/wireless/marvell/mwifiex/wmm.c
> > > b/drivers/net/wireless/marvell/mwifiex/wmm.c
> > > index bcb61dab7dc86..1b1222c73728f 100644
> > > --- a/drivers/net/wireless/marvell/mwifiex/wmm.c
> > > +++ b/drivers/net/wireless/marvell/mwifiex/wmm.c
> > > @@ -1428,13 +1428,13 @@ mwifiex_dequeue_tx_packet(struct
> > > mwifiex_adapter *adapter)
> > >         }
> > >
> > >         if (!ptr->is_11n_enabled ||
> > > -               ptr->ba_status ||
> > > -               priv->wps.session_enable) {
> > > +           ptr->ba_status ||
> > > +           priv->wps.session_enable) {
> > >                 if (ptr->is_11n_enabled &&
> > > -                       ptr->ba_status &&
> > > -                       ptr->amsdu_in_ampdu &&
> > > -                       mwifiex_is_amsdu_allowed(priv, tid) &&
> > > -                       mwifiex_is_11n_aggragation_possible(priv,
> ptr,
> > > +                   ptr->ba_status &&
> > > +                   ptr->amsdu_in_ampdu &&
> > > +                   mwifiex_is_amsdu_allowed(priv, tid) &&
> > > +                   mwifiex_is_11n_aggragation_possible(priv, ptr,
> > >
> > > adapter->tx_buf_size))
> > >                         mwifiex_11n_aggregate_pkt(priv, ptr,
> ptr_index);
> > >                         /* ra_list_spinlock has been freed in
> > >
> > > --
> > > 2.39.2
> > >
> >
> > I wonder we still need patch for indent issue here? If so I am sure we
> > will need a bunch of similar patches which I don't think really help
> > improve mwifiex quality
> >
> > Actually in its successor Nxpwifi (currently under review), we have
> > cleaned up all indent, and checkpatch errors/warnings/checks.
> 
> BTW you advertised nxpwifi not as a successor to mwifiex, but as the driver to
> be used for new chips. This means we still have to deal with the mwifiex driver
> in the future to support the old chips, so even if nxpwifi is merged it still makes
> sense to clean up mwifiex.
> 
> Sascha
> 

Just like what I listed for the errors/warning/checks of Mwifiex running with checkpatch.
Mwifiex has so many issues. As the driver will only support legacy devices and the state of
it is "Odd fixes", It is better to fix really bugs of Mwifiex instead of cleanup it.

David