linux-kernel - Re: [PATCH] ALSA: hda: hda_component: Fix mutex crash if nothing ever binds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87frqriord.wl-tiwai@suse.de>
Date: Mon, 26 Aug 2024 12:04:22 +0200
From: Takashi Iwai <tiwai@...e.de>
To: Richard Fitzgerald <rf@...nsource.cirrus.com>
Cc: <tiwai@...e.com>,
	<linux-sound@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>,
	<patches@...nsource.cirrus.com>
Subject: Re: [PATCH] ALSA: hda: hda_component: Fix mutex crash if nothing ever binds

On Mon, 26 Aug 2024 11:49:40 +0200,
Richard Fitzgerald wrote:
> 
> Move the initialization of parent->mutex into
> hda_component_manager_init() so that it is always valid.
> 
> In hda_component_manager_bind() do not clear the parent information.
> Only zero-fill the per-component data ready for it to be filled in
> by the components as they bind.
> 
> Previously parent->mutex was being initialized only in
> hda_component_manager_bind(). This meant that it was only
> initialized if all components appeared and there was a bind callback.
> If there wasn't a bind the mutex object was not valid when the
> Realtek driver called any of the other functions.
> 
> Signed-off-by: Richard Fitzgerald <rf@...nsource.cirrus.com>
> Fixes: 047b9cbbaa8e ("ALSA: hda: hda_component: Protect shared data with a mutex")

Thanks, applied now to for-linus branch.


Takashi