linux-kernel - Re: [PATCH v4 1/4] iio: magnetometer: ak8975: Relax failure on unknown id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240826113920.092d9ec7@jic23-huawei>
Date: Mon, 26 Aug 2024 11:39:20 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
Cc: Barnabás Czémán <barnabas.czeman@...nlining.org>,
 Lars-Peter Clausen <lars@...afoo.de>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Jonathan Albrieux <jonathan.albrieux@...il.com>,
 Gwendal Grignou <gwendal@...omium.org>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 linux@...nlining.org
Subject: Re: [PATCH v4 1/4] iio: magnetometer: ak8975: Relax failure on
 unknown id

On Fri, 23 Aug 2024 22:11:15 +0300
Andy Shevchenko <andriy.shevchenko@...el.com> wrote:

> On Fri, Aug 23, 2024 at 07:32:03PM +0100, Jonathan Cameron wrote:
> > On Mon, 19 Aug 2024 00:29:39 +0200
> > Barnabás Czémán <barnabas.czeman@...nlining.org> wrote:  
> 
> ...
> 
> > > +	/* Let driver to probe on unknown id for support more register  
> > Comment style wrong, I'll fix it up.
> > 
> > With that tweak applied to the togreg branch of iio.git
> > 
> > Thanks,
> > 
> > Jonathan
> > 
> >   
> > > +	 * compatible variants.
> > > +	 */  
> 
> There is another one also wrong.
> 
> +	[AK09918] = {
> +		/* ak09918 is register compatible with ak09912 this is for avoid
> +		 * unknown id messages.
> +		 */
> 
> 

I think unrelated to this series, but nice to cleanup.
Patches welcome :) Or it I get bored, I might do a scrub of the full subsystem
to get everything in the same style and not provide incorrect choices to
cut and paste.

Jonathan