linux-kernel - Re: [PATCH v3 1/2] iio: adc: xilinx-ams: use device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <66609a52-6a30-4642-9fff-5e41f58add6e@amd.com>
Date: Mon, 26 Aug 2024 13:15:17 +0200
From: Michal Simek <michal.simek@....com>
To: Jonathan Cameron <jic23@...nel.org>,
 Javier Carrasco <javier.carrasco.cruz@...il.com>,
 "O'Griofa, Conall" <conall.ogriofa@....com>
Cc: Suzuki K Poulose <suzuki.poulose@....com>,
 Mike Leach <mike.leach@...aro.org>, James Clark <james.clark@...aro.org>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Michael Hennerich <Michael.Hennerich@...log.com>,
 Lars-Peter Clausen <lars@...afoo.de>,
 Anand Ashok Dumbre <anand.ashok.dumbre@...inx.com>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>, Pavel Machek <pavel@....cz>,
 Lee Jones <lee@...nel.org>, coresight@...ts.linaro.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-iio@...r.kernel.org, linux-leds@...r.kernel.org
Subject: Re: [PATCH v3 1/2] iio: adc: xilinx-ams: use device_* to iterate over
 device child nodes

Hi Jonathan,

On 8/26/24 12:52, Jonathan Cameron wrote:
> On Tue, 20 Aug 2024 21:02:26 +0200
> Javier Carrasco <javier.carrasco.cruz@...il.com> wrote:
> 
>> Use `device_for_each_child_node_scoped()` in `ams_parse_firmware()`
>> to explicitly state device child node access, and simplify the child
>> node handling as it is not required outside the loop.
>>
>> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>
> Applied, but I would ideally still like one of the xilinx folk
> others familiar with this driver to take a look.  It'll be a
> few days before this ends up in next anyway as I need to rebase
> after Greg (hopefully) takes the pull request from last week.

I just get back from vacation.

> 
> It would be lovely to get rid of the direct fwnode usage
> in here but I'm not 100% sure if there is a path that will land
> on a disabled fwnode.

Conall: Please take a look at this and test it.

Thanks,
Michal