linux-kernel - Re: [syzbot] WARNING: lock held when returning to user space in ethnl_act_cable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <000000000000a3bc54062094a3a9@google.com>
Date: Mon, 26 Aug 2024 04:43:52 -0700
From: syzbot <syzbot+c641161e97237326ea74@...kaller.appspotmail.com>
To: linux-kernel@...r.kernel.org
Subject: Re: [syzbot] WARNING: lock held when returning to user space in ethnl_act_cable_test

For archival purposes, forwarding an incoming command email to
linux-kernel@...r.kernel.org.

***

Subject: WARNING: lock held when returning to user space in ethnl_act_cable_test
Author: djahchankoike@...il.com

#syz test

Fix an unreleased lock when taking the out_dev_put path.

Signed-off-by: Diogo Jahchan Koike <djahchankoike@...il.com>
---
I'm not entirely sure why are there two labels
when all paths should release the lock, maybe
remove out_dev_put and out_rtnl for a simpler
out? I've kept it just in case, but I can make
the change if needed.
---
 net/ethtool/cabletest.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/ethtool/cabletest.c b/net/ethtool/cabletest.c
index 01db8f394869..c6ca1107c470 100644
--- a/net/ethtool/cabletest.c
+++ b/net/ethtool/cabletest.c
@@ -77,6 +77,7 @@ int ethnl_act_cable_test(struct sk_buff *skb, struct genl_info *info)
 				      info->extack);
 	if (IS_ERR_OR_NULL(phydev)) {
 		ret = -EOPNOTSUPP;
+		rtnl_unlock();
 		goto out_dev_put;
 	}
 
-- 
2.43.0