linux-kernel - Re: [PATCH] net: fix unreleased lock in ethnl_act_cable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9ac272e6-b956-434b-a90b-60be6a5ad106@lunn.ch>
Date: Mon, 26 Aug 2024 15:05:38 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Diogo Jahchan Koike <djahchankoike@...il.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, maxime.chevallier@...tlin.com,
	christophe.leroy@...roup.eu, linux@...blig.org,
	linux-kernel@...r.kernel.org,
	linux-kernel-mentees@...ts.linuxfoundation.org,
	syzkaller-bugs@...glegroups.com,
	syzbot+c641161e97237326ea74@...kaller.appspotmail.com
Subject: Re: [PATCH] net: fix unreleased lock in ethnl_act_cable_test

On Mon, Aug 26, 2024 at 09:14:15AM -0300, Diogo Jahchan Koike wrote:
> fix an unreleased lock in out_dev_put path and substitute
> both labels (out_rtnl and out_dev_put) for a simpler out.

Hi Diogo

We try to keep fixes simple. I would of changed the out_dev_put to
out_rtnl, and then removed the unused out_dev_put. That makes the
change smaller, more obviously correct.

As far as i can see, 3688ff3077d3 is only in net-next, not an -rc
kernel. As such, we want this patch added to net-next. You indicate
this in the patch Subject: [path net-next v2].

Thanks

    Andrew

---
pw-bot: cr