linux-kernel - Re: [PATCH] bus: bt1-axi: change to use devm_clk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202408262130.M4pjxUDC-lkp@intel.com>
Date: Mon, 26 Aug 2024 21:29:39 +0800
From: kernel test robot <lkp@...el.com>
To: Wu Bo <bo.wu@...o.com>, linux-kernel@...r.kernel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	Serge Semin <fancer.lancer@...il.com>, linux-mips@...r.kernel.org,
	Wu Bo <wubo.oduw@...il.com>
Subject: Re: [PATCH] bus: bt1-axi: change to use devm_clk_get_enabled()
 helpers

Hi Wu,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.11-rc5 next-20240826]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Wu-Bo/bus-bt1-axi-change-to-use-devm_clk_get_enabled-helpers/20240826-122401
base:   linus/master
patch link:    https://lore.kernel.org/r/20240823023103.1984437-1-bo.wu%40vivo.com
patch subject: [PATCH] bus: bt1-axi: change to use devm_clk_get_enabled() helpers
config: arm-randconfig-002-20240826 (https://download.01.org/0day-ci/archive/20240826/202408262130.M4pjxUDC-lkp@intel.com/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 08e5a1de8227512d4774a534b91cb2353cef6284)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240826/202408262130.M4pjxUDC-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408262130.M4pjxUDC-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/bus/bt1-axi.c:158:9: warning: variable 'ret' is uninitialized when used here [-Wuninitialized]
     158 |         return ret;
         |                ^~~
   drivers/bus/bt1-axi.c:151:9: note: initialize the variable 'ret' to silence this warning
     151 |         int ret;
         |                ^
         |                 = 0
   1 warning generated.


vim +/ret +158 drivers/bus/bt1-axi.c

63cb77136e04ff Serge Semin 2020-05-26  148  
63cb77136e04ff Serge Semin 2020-05-26  149  static int bt1_axi_request_clk(struct bt1_axi *axi)
63cb77136e04ff Serge Semin 2020-05-26  150  {
63cb77136e04ff Serge Semin 2020-05-26  151  	int ret;
63cb77136e04ff Serge Semin 2020-05-26  152  
6ac8fb96f7dfde Wu Bo       2024-08-22  153  	axi->aclk = devm_clk_get_enabled(axi->dev, "aclk");
5e93207e962a6d Serge Semin 2022-06-10  154  	if (IS_ERR(axi->aclk))
5e93207e962a6d Serge Semin 2022-06-10  155  		return dev_err_probe(axi->dev, PTR_ERR(axi->aclk),
5e93207e962a6d Serge Semin 2022-06-10  156  				     "Couldn't get AXI Interconnect clock\n");
63cb77136e04ff Serge Semin 2020-05-26  157  
7f57416f2aebe6 Serge Semin 2020-05-28 @158  	return ret;
63cb77136e04ff Serge Semin 2020-05-26  159  }
63cb77136e04ff Serge Semin 2020-05-26  160  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki