linux-kernel - Re: [PATCH v1] drivers:mgb4:Fix the NULL vs IS_ERR() bug for debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <15346558-07e3-4c25-a65f-843e5d39dc45@gpxsee.org>
Date: Mon, 26 Aug 2024 15:36:23 +0200
From: Martin Tůma <tumic@...see.org>
To: Yang Ruibin <11162571@...o.com>,
 Martin Tuma <martin.tuma@...iteqautomotive.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, linux-media@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: opensource.kernel@...o.com
Subject: Re: [PATCH v1] drivers:mgb4:Fix the NULL vs IS_ERR() bug for
 debugfs_create_dir()

On 21. 08. 24 9:29 dop., Yang Ruibin wrote:
> The debugfs_create_dir() function returns error pointers.
> It never returns NULL. So use IS_ERR() to check it.
> 
> Signed-off-by: Yang Ruibin <11162571@...o.com>
> ---
>   drivers/media/pci/mgb4/mgb4_vin.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/pci/mgb4/mgb4_vin.c b/drivers/media/pci/mgb4/mgb4_vin.c
> index e9332abb3172..808eb51b270c 100644
> --- a/drivers/media/pci/mgb4/mgb4_vin.c
> +++ b/drivers/media/pci/mgb4/mgb4_vin.c
> @@ -860,7 +860,7 @@ static void debugfs_init(struct mgb4_vin_dev *vindev)
>   
>   	vindev->debugfs = debugfs_create_dir(vindev->vdev.name,
>   					     vindev->mgbdev->debugfs);
> -	if (!vindev->debugfs)
> +	if (IS_ERR(vindev->debugfs))
>   		return;
>   
>   	vindev->regs[0].name = "CONFIG";

Superseded by
 
https://patchwork.linuxtv.org/project/linux-media/patch/20240826132604.3240-2-tumic@gpxsee.org/
that handles both the input/output device cases as well as an error when 
creating the parent mgb4(PCIe) device.

M.