linux-kernel - Re: [PATCH v1] netronome: nfp: Use min macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240827072423.4540bed6@kernel.org>
Date: Tue, 27 Aug 2024 07:24:23 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Yan Zhen <yanzhen@...o.com>
Cc: louis.peens@...igine.com, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, oss-drivers@...igine.com, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, opensource.kernel@...o.vom
Subject: Re: [PATCH v1] netronome: nfp: Use min macro

On Tue, 27 Aug 2024 16:40:05 +0800 Yan Zhen wrote:
> Using min macro not only makes the code more concise and readable
> but also improves efficiency sometimes.

The code is fine, you're making it worse.

How many of those pointless min()/max() conversions do you have 
for drivers/net ?
-- 
pw-bot: reject