linux-kernel - Re: [PATCH 1/3] net: hisilicon: hip04: fix OF node leak in probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6b483487-1806-424c-8237-07c0de481790@linaro.org>
Date: Tue, 27 Aug 2024 16:41:50 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Simon Horman <horms@...nel.org>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Salil Mehta <salil.mehta@...wei.com>,
 Yisen Zhuang <yisen.zhuang@...wei.com>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] net: hisilicon: hip04: fix OF node leak in probe()

On 27/08/2024 16:40, Simon Horman wrote:
> On Sun, Aug 25, 2024 at 09:21:31PM +0200, Markus Elfring wrote:
>>> Driver is leaking OF node reference from
>>> of_parse_phandle_with_fixed_args() in probe().
>>
>> * Is there a need to improve such a change description another bit?
>>
>>   + Imperative mood
>>
>>   * Tags like “Fixes” and “Cc”
> 
> I think it would be helpful if these were either explicitly targeted for
> net-next without Fixes tags (the assumed state of affairs as-is).
> 
> 	Subject: [Patch x/n net-next] ...
> 
> Or targeted at net, with Fixes tags
> 
> 	Subject: [Patch x/n net] ...
> 
> I guess that in theory these are fixes, as resource leaks could occur.
> But perhaps that is more theory that practice. I am unsure.

I'll resend with net-next.

Best regards,
Krzysztof