linux-kernel - Re: [PATCH 0/8] regulator: kerneldoc section fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zs3mtN-vPnVtppY-@smile.fi.intel.com>
Date: Tue, 27 Aug 2024 17:46:12 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Chen-Yu Tsai <wenst@...omium.org>
Cc: Mark Brown <broonie@...nel.org>, Liam Girdwood <lgirdwood@...il.com>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 0/8] regulator: kerneldoc section fixes

On Tue, Aug 27, 2024 at 05:55:40PM +0800, Chen-Yu Tsai wrote:
> Hi,
> 
> Here are a bunch of kerneldoc fixes for the regulator core. This sort of
> came as a request from Andy to not move code that already had warnings

You can add Reported-by: or Suggested-by to the cover letter.

> without fixing said warnings. So here I'm fixing them first.
> 
> The bulk of the fixes are in the regulator core and OF code, but I also
> fixed up a few bits in common code that were missing "Return" sections.
> These are purely kerneldoc fixes and don't touch any actual code. I left
> the devres code and helpers alone for now.

Thanks for doing this!

I briefly looked at them, the main two remarks are:
1) definite vs. indefinite article;
2) same and consistent term for negative error codes (or numbers if you
prefer).

Otherwise LGTM!

-- 
With Best Regards,
Andy Shevchenko