linux-kernel - Re: [PATCH] net: bridge: fix switchdev host mdb entry updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <02024954-6ea6-47ca-9f89-2e66fe268f7f@nbd.name>
Date: Tue, 27 Aug 2024 17:56:52 +0200
From: Felix Fietkau <nbd@....name>
To: Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
 Roopa Prabhu <roopa@...dia.com>, Nikolay Aleksandrov <razor@...ckwall.org>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>
Cc: bridge@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: bridge: fix switchdev host mdb entry updates

On 27.08.24 13:03, Paolo Abeni wrote:
> Hi,
> 
> On 8/22/24 18:38, Felix Fietkau wrote:
>> When a mdb entry is removed, the bridge switchdev code can issue a
>> switchdev_port_obj_del call for a port that was not offloaded.
>> 
>> This leads to an imbalance in switchdev_port_obj_add/del calls, since
>> br_switchdev_mdb_replay has not been called for the port before.
>> 
>> This can lead to potential multicast forwarding issues and messages such as:
>> mt7915e 0000:01:00.0 wl1-ap0: Failed to del Host Multicast Database entry
>> 	(object id=3) with error: -ENOENT (-2).
>> 
>> Fix this issue by checking the port offload status when iterating over
>> lower devs.
>> 
>> Signed-off-by: Felix Fietkau <nbd@....name>
> 
> This looks like a fix suitable for the net tree and deserving a fixes
> tag. Could you please repost adding both the target tree prefix and tag?

Looking at the code changes, I wasn't able to figure out which commit 
introduced the bug. Do you have any ideas what commit I could reference 
in the Fixes tag?

- Felix