linux-kernel - Re: [PATCH 2/2] arm64: dts: ti: iot2050: Add overlays for M.2 used by firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <22f22118-58f0-4974-8327-736181c71aa7@siemens.com>
Date: Tue, 27 Aug 2024 18:20:56 +0200
From: Jan Kiszka <jan.kiszka@...mens.com>
To: Rob Herring <robh+dt@...nel.org>
Cc: Nishanth Menon <nm@...com>, Vignesh Raghavendra <vigneshr@...com>,
 Tero Kristo <kristo@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 Bao Cheng Su <baocheng.su@...mens.com>, Hua Qian Li <huaqian.li@...mens.com>
Subject: Re: [PATCH 2/2] arm64: dts: ti: iot2050: Add overlays for M.2 used by
 firmware

On 27.08.24 17:33, Rob Herring wrote:
> On Mon, Aug 26, 2024 at 9:29 AM Jan Kiszka <jan.kiszka@...mens.com> wrote:
>>
>> From: Jan Kiszka <jan.kiszka@...mens.com>
>>
>> To allow firmware to pick up all DTs from here, move the overlays that
>> are normally applied during DT fixup to the kernel source as well. Hook
>> then into the build nevertheless to ensure that regular checks are
>> performed.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@...mens.com>
>> ---
>>  arch/arm64/boot/dts/ti/Makefile               |  2 +
>>  ...48-iot2050-advanced-m2-bkey-ekey-pcie.dtso | 27 +++++++++++
>>  ...-am6548-iot2050-advanced-m2-bkey-usb3.dtso | 47 +++++++++++++++++++
>>  3 files changed, 76 insertions(+)
>>  create mode 100644 arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-m2-bkey-ekey-pcie.dtso
>>  create mode 100644 arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-m2-bkey-usb3.dtso
>>
>> diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile
>> index e20b27ddf901..f459af7fac0d 100644
>> --- a/arch/arm64/boot/dts/ti/Makefile
>> +++ b/arch/arm64/boot/dts/ti/Makefile
>> @@ -77,6 +77,8 @@ dtb-$(CONFIG_ARCH_K3) += k3-am6528-iot2050-basic.dtb
>>  dtb-$(CONFIG_ARCH_K3) += k3-am6528-iot2050-basic-pg2.dtb
>>  dtb-$(CONFIG_ARCH_K3) += k3-am6548-iot2050-advanced.dtb
>>  dtb-$(CONFIG_ARCH_K3) += k3-am6548-iot2050-advanced-m2.dtb
>> +dtb-$(CONFIG_ARCH_K3) += k3-am6548-iot2050-advanced-m2-bkey-ekey-pcie.dtbo
>> +dtb-$(CONFIG_ARCH_K3) += k3-am6548-iot2050-advanced-m2-bkey-usb3.dtbo
> 
> You are missing applying these overlays to anything. That is a
> requirement for any overlay in the tree.

You mean apply for testing purposes? How, technically?

Or is that about actual usage by the kernel? I was sent here from a
U-Boot discussion where we would like to consume all DTS files from the
kernel [1]. In our case, the kernel will not use these overlays, the
firmware does, presenting the result to the kernel during runtime.

Jan

[1]
https://lore.kernel.org/u-boot/CAFA6WYNXgJkCX9-aoL5FGchAHGdV+ikTt4+pTJP-jZ_UJG8E6Q@mail.gmail.com/

-- 
Siemens AG, Technology
Linux Expert Center