linux-kernel - Re: [PATCH v2] hwmon: (pt5161l) Fix invalid temperature reading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c16f3254-36c1-4ec3-ac09-ca15ed547413@roeck-us.net>
Date: Mon, 26 Aug 2024 20:58:28 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Cosmo Chou <chou.cosmo@...il.com>
Cc: jdelvare@...e.com, linux-hwmon@...r.kernel.org,
	linux-kernel@...r.kernel.org, cosmo.chou@...ntatw.com
Subject: Re: [PATCH v2] hwmon: (pt5161l) Fix invalid temperature reading

On Mon, Aug 19, 2024 at 06:46:30PM +0800, Cosmo Chou wrote:
> The temperature reading function was using a signed long for the ADC
> code, which could lead to mishandling of invalid codes on 32-bit
> platforms. This allowed out-of-range ADC codes to be incorrectly
> interpreted as valid values and used in temperature calculations.
> 
> Change adc_code to u32 to ensure that invalid ADC codes are correctly
> identified on all platforms.
> 
> Fixes: 1b2ca93cd059 ("hwmon: Add driver for Astera Labs PT5161L retimer")
> Signed-off-by: Cosmo Chou <chou.cosmo@...il.com>

Applied.

Thanks,
Guenter