linux-kernel - Re: [PATCH] loop: Increase bsize variable from unsigned short to unsigned int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a7585769-5e2d-4ecd-8dd4-2f8f04243c05@kernel.org>
Date: Tue, 27 Aug 2024 13:10:06 +0900
From: Damien Le Moal <dlemoal@...nel.org>
To: Li Wang <liwang@...hat.com>, linux-kernel@...r.kernel.org,
 ltp@...ts.linux.it
Cc: Jan Stancek <jstancek@...hat.com>, John Garry <john.g.garry@...cle.com>,
 Stefan Hajnoczi <stefanha@...hat.com>
Subject: Re: [PATCH] loop: Increase bsize variable from unsigned short to
 unsigned int

On 8/27/24 12:22, Li Wang wrote:
> This change allows the loopback driver to handle larger block sizes
> and increases the consistency of data types used within the driver.
> Especially to mactch the struct queue_limits.logical_block_size type.
> 
> Also, this is to get rid of the LTP/ioctl_loop06 test failure:
> 
>   12 ioctl_loop06.c:76: TINFO: Using LOOP_SET_BLOCK_SIZE with arg > PAGE_SIZE
>   13 ioctl_loop06.c:59: TFAIL: Set block size succeed unexpectedly
>   ...
>   18 ioctl_loop06.c:76: TINFO: Using LOOP_CONFIGURE with block_size > PAGE_SIZE
>   19 ioctl_loop06.c:59: TFAIL: Set block size succeed unexpectedly
> 
> Link: https://lists.linux.it/pipermail/ltp/2024-August/039912.html
> Signed-off-by: Li Wang <liwang@...hat.com>
> Cc: Jan Stancek <jstancek@...hat.com>
> Cc: John Garry <john.g.garry@...cle.com>
> Cc: Damien Le Moal <dlemoal@...nel.org>
> Cc: Stefan Hajnoczi <stefanha@...hat.com>

Looks OK to me.

Reviewed-by: Damien Le Moal <dlemoal@...nel.org>

-- 
Damien Le Moal
Western Digital Research