linux-kernel - Re: [PATCH] staging: rtl87212: Match parenthesis alignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3871ba3a-4742-4106-89a7-8fa8deb6598e@gmail.com>
Date: Tue, 27 Aug 2024 20:56:39 +0200
From: Philipp Hortmann <philipp.g.hortmann@...il.com>
To: Dorine Tipo <dorine.a.tipo@...il.com>,
 Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl87212: Match parenthesis alignment

On 8/27/24 10:18, Dorine Tipo wrote:
> Fix the parenthesis alignment in r8712_read_port() function to match
> the opening parenthesis
> 
> Signed-off-by: Dorine Tipo <dorine.a.tipo@...il.com>
> ---
>   drivers/staging/rtl8712/usb_ops_linux.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8712/usb_ops_linux.c b/drivers/staging/rtl8712/usb_ops_linux.c
> index 0a3451cdc8a1..4a34824830e3 100644
> --- a/drivers/staging/rtl8712/usb_ops_linux.c
> +++ b/drivers/staging/rtl8712/usb_ops_linux.c
> @@ -221,7 +221,7 @@ static void r8712_usb_read_port_complete(struct urb *purb)
>   			fallthrough;
>   		case -EPROTO:
>   			r8712_read_port(padapter, precvpriv->ff_hwaddr, 0,
> -				  (unsigned char *)precvbuf);
> +					(unsigned char *)precvbuf);
>   			break;
>   		case -EINPROGRESS:
>   			netdev_err(padapter->pnetdev, "ERROR: URB IS IN PROGRESS!\n");
> --
> 2.25.1
> 
> 

Hi Dorine,

please correct the typo in the subject. ("rtl8712")

Please make your "Subject" line more unique. Consider that we may end up 
with having dozen of commits like yours, all of them referring to 
different removals and all without the necessary information to tell 
what they differ in (except the driver/subsystem). So it would help if 
you add the changed file or function to make it more unique.

Please use a dot to end the sentences in the description.
You described a why but may be you can improve the description with the 
why for the reader. For example by adding ... to improve readability.

If you send in a second version of this patch please use a change 
history. Description from Dan under:
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

Thanks for your support.

Bye Philipp