linux-kernel - Re: [PATCH v2] rust: add `module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALNs47vwhV-DRzPbvE22vefaROmjj_5SCLuyQrfKvy=Q4Ou9WQ@mail.gmail.com>
Date: Tue, 27 Aug 2024 15:11:05 -0400
From: Trevor Gross <tmgross@...ch.edu>
To: Andreas Hindborg <nmi@...aspace.dk>
Cc: Luis Chamberlain <mcgrof@...nel.org>, Miguel Ojeda <ojeda@...nel.org>, 
	Alex Gaynor <alex.gaynor@...il.com>, Wedson Almeida Filho <wedsonaf@...il.com>, 
	Andreas Hindborg <a.hindborg@...sung.com>, Adam Bratschi-Kaye <ark.email@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Alice Ryhl <aliceryhl@...gle.com>, 
	Daniel Gomez <da.gomez@...sung.com>, rust-for-linux@...r.kernel.org, 
	linux-modules@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] rust: add `module_params` macro

On Tue, Aug 27, 2024 at 10:00 AM Andreas Hindborg <nmi@...aspace.dk> wrote:
>
> "Trevor Gross" <tmgross@...ch.edu> writes:
>
> > On Mon, Aug 19, 2024 at 8:35 AM Andreas Hindborg <nmi@...aspace.dk> wrote:
> >>
> >> From: Andreas Hindborg <a.hindborg@...sung.com>
> >>
> >> This patch includes changes required for Rust kernel modules to utilize
> >> module parameters. This code implements read only support for integer
> >> types without `sysfs` support.
> >
> > Also, I think the subject line needs an update ("rust: add
> > `module_params` macro")
>
> Well, it is still what it does. Plus few support types. You think it is
> not descriptive enough?

Maybe it should just say 'Add parameter support to the `module!`
macro'? The text `module_params` doesn't seem to appear in the patch,
I was looking for something like `module_params!`.

- Trevor

> BR Andreas