linux-kernel - Re: [PATCH] iomap: remove set_memor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240827055539.GL865349@frogsfrogsfrogs>
Date: Mon, 26 Aug 2024 22:55:39 -0700
From: "Darrick J. Wong" <djwong@...nel.org>
To: Luis Chamberlain <mcgrof@...nel.org>
Cc: brauner@...nel.org, sfr@...b.auug.org.au, p.raghav@...sung.com,
	dchinner@...hat.com, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-xfs@...r.kernel.org,
	linux-next@...r.kernel.org
Subject: Re: [PATCH] iomap: remove set_memor_ro() on zero page

On Mon, Aug 26, 2024 at 02:26:32PM -0700, Luis Chamberlain wrote:
> Stephen reported a boot failure on ppc power8 system where
> set_memor_ro() on the new zero page failed [0]. Christophe Leroy
> further clarifies we can't use this on on linear memory on ppc, and
> so instead of special casing this just for PowerPC [2] remove the
> call as suggested by Darrick.
> 
> [0] https://lore.kernel.org/all/20240826175931.1989f99e@canb.auug.org.au/T/#u
> [1] https://lore.kernel.org/all/b0fe75b4-c1bb-47f7-a7c3-2534b31c1780@csgroup.eu/
> [2] https://lore.kernel.org/all/ZszrJkFOpiy5rCma@bombadil.infradead.org/
> 
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Suggested-by: "Darrick J. Wong" <djwong@...nel.org>
> Signed-off-by: Luis Chamberlain <mcgrof@...nel.org>

Reviewed-by: Darrick J. Wong <djwong@...nel.org>

--D

> ---
> 
> This applies to the vfs.blocksize branch on the vfs tree.
> 
>  fs/iomap/direct-io.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c
> index c02b266bba52..f637aa0706a3 100644
> --- a/fs/iomap/direct-io.c
> +++ b/fs/iomap/direct-io.c
> @@ -11,7 +11,6 @@
>  #include <linux/iomap.h>
>  #include <linux/backing-dev.h>
>  #include <linux/uio.h>
> -#include <linux/set_memory.h>
>  #include <linux/task_io_accounting_ops.h>
>  #include "trace.h"
>  
> @@ -781,8 +780,6 @@ static int __init iomap_dio_init(void)
>  	if (!zero_page)
>  		return -ENOMEM;
>  
> -	set_memory_ro((unsigned long)page_address(zero_page),
> -		      1U << IOMAP_ZERO_PAGE_ORDER);
>  	return 0;
>  }
>  fs_initcall(iomap_dio_init);
> -- 
> 2.43.0
> 
>