linux-kernel - Re: [PATCH -next 1/2] spi: atmel-quadspi: Fix uninitialized res

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ad454e33-9ea0-4b94-a97f-38fd868af247@microchip.com>
Date: Tue, 27 Aug 2024 06:01:46 +0000
From: <Hari.PrasathGE@...rochip.com>
To: <ruanjinjie@...wei.com>, <broonie@...nel.org>,
	<Nicolas.Ferre@...rochip.com>, <alexandre.belloni@...tlin.com>,
	<claudiu.beznea@...on.dev>, <linux-spi@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next 1/2] spi: atmel-quadspi: Fix uninitialized res

Hello,

On 8/26/24 6:29 PM, Jinjie Ruan wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> The second platform_get_resource_byname() can not be replaced with
> devm_platform_ioremap_resource_byname(), because the intermediate "res"
> is used to assign for "aq->mmap_size".
> 

Yes indeed.

I see that the above commit is merged in the SPI git tree. With that,

Acked-by: Hari Prasath Gujulan Elango <hari.prasathge@...rochip.com>

Regards,
Hari

> Fixes: 3ccea1dedef3 ("spi: atmel-quadspi: Simpify resource lookup")
> Signed-off-by: Jinjie Ruan <ruanjinjie@...wei.com>
> ---
>   drivers/spi/atmel-quadspi.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/atmel-quadspi.c b/drivers/spi/atmel-quadspi.c
> index 2b5c72176711..56dd8dcb86cb 100644
> --- a/drivers/spi/atmel-quadspi.c
> +++ b/drivers/spi/atmel-quadspi.c
> @@ -608,7 +608,8 @@ static int atmel_qspi_probe(struct platform_device *pdev)
>          }
> 
>          /* Map the AHB memory */
> -       aq->mem = devm_platform_ioremap_resource_byname(pdev, "qspi_mmap");
> +       res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "qspi_mmap");
> +       aq->mem = devm_ioremap_resource(&pdev->dev, res);
>          if (IS_ERR(aq->mem)) {
>                  dev_err(&pdev->dev, "missing AHB memory\n");
>                  return PTR_ERR(aq->mem);
> --
> 2.34.1
> 
>