linux-kernel - Re: [PATCH -fixes] drivers: perf: Fix smp_processor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHVXubh+yEROx-P0iS06J4BSc9bBzi8D_FUFAG5mHXAvuE7TpQ@mail.gmail.com>
Date: Tue, 27 Aug 2024 08:06:26 +0200
From: Alexandre Ghiti <alexghiti@...osinc.com>
To: Andrea Parri <parri.andrea@...il.com>
Cc: Atish Patra <atishp@...shpatra.org>, Anup Patel <anup@...infault.org>, 
	Will Deacon <will@...nel.org>, Mark Rutland <mark.rutland@....com>, 
	Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>, 
	Albert Ou <aou@...s.berkeley.edu>, linux-riscv@...ts.infradead.org, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	Nam Cao <namcao@...utronix.de>
Subject: Re: [PATCH -fixes] drivers: perf: Fix smp_processor_id() use in
 preemptible code

Hi Andrea,

On Mon, Aug 26, 2024 at 9:36 PM Andrea Parri <parri.andrea@...il.com> wrote:
>
> On Mon, Aug 26, 2024 at 06:52:10PM +0200, Alexandre Ghiti wrote:
> > As reported in [1], the use of smp_processor_id() in
> > pmu_sbi_device_probe() must be protected by disabling the preemption, so
> > simple use get_cpu()/put_cpu() instead.
>
>   simply
>
>
> > Reported-by: Nam Cao <namcao@...utronix.de>
>
> Reported-by: Andrea Parri <parri.andrea@...il.com>

I added it at first but since there is no link to a bug report,
checkpatch complains so I removed it. But I have just checked the
documentation which states:

"The tag should be followed by a Closes: tag pointing to the report,
unless the report is not available on the web"

So I'm sorry about that, it won't happen again.

Thanks,

Alex


>
>
> > Closes: https://lore.kernel.org/linux-riscv/20240820074925.ReMKUPP3@linutronix.de/ [1]
> > Signed-off-by: Alexandre Ghiti <alexghiti@...osinc.com>
>
> Tested-by: Andrea Parri <parri.andrea@...il.com>
>
>   Andrea