linux-kernel - Re: [PATCH 1/2] dt-bindings: soc: rockchip: Fix compatibles for RK3588 VO{0,1}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5c5juu2ug5wmtzcokvwav2vls2f43ryom6mjrqc27uytscax6d@hj4qfezdrf7u>
Date: Tue, 27 Aug 2024 08:56:58 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
Cc: Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Heiko Stuebner <heiko@...ech.de>, kernel@...labora.com, devicetree@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	Conor Dooley <conor@...nel.org>
Subject: Re: [PATCH 1/2] dt-bindings: soc: rockchip: Fix compatibles for
 RK3588 VO{0,1}_GRF

On Tue, Aug 27, 2024 at 02:06:50AM +0300, Cristian Ciocaltea wrote:
> According to RK3588 TRM, VO0_GRF and VO1_GRF have a similar layout, but
> definitely not an identical one, therefore sharing the compatible is not
> really justified.
> 
> Since currently there is no user of this, hence no ABI break, let's fix
> it by providing dedicated strings.
> 
> Reported-by: Conor Dooley <conor@...nel.org>
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
> ---
>  Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> index 78c6d5b64138..8fd539125f4a 100644
> --- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> +++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> @@ -31,7 +31,8 @@ properties:
>                - rockchip,rk3588-pcie3-pipe-grf
>                - rockchip,rk3588-usb-grf
>                - rockchip,rk3588-usbdpphy-grf
> -              - rockchip,rk3588-vo-grf

You should deprecate the old one instead (deprecated: true).

Best regards,
Krzysztof