[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMuHMdV0R0+u1eCiUOHhL5w-wzge9KhgyumJSd28oF9kQmnx_Q@mail.gmail.com>
Date: Tue, 27 Aug 2024 09:48:09 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Ulf Hansson <ulf.hansson@...aro.org>, Heiko Stuebner <heiko@...ech.de>,
Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>,
Bjorn Andersson <andersson@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>,
Geert Uytterhoeven <geert+renesas@...der.be>, Magnus Damm <magnus.damm@...il.com>,
linux-pm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
imx@...ts.linux.dev, linux-arm-msm@...r.kernel.org,
linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH 09/10] pmdomain: renesas: rcar-gen4-sysc: Use scoped
device node handling to simplify error paths
Hi Krzysztof,
On Fri, Aug 23, 2024 at 2:51 PM Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
> Obtain the device node reference with scoped/cleanup.h to reduce error
> handling and make the code a bit simpler.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Thanks for your patch!
> --- a/drivers/pmdomain/renesas/rcar-gen4-sysc.c
> +++ b/drivers/pmdomain/renesas/rcar-gen4-sysc.c
> @@ -303,12 +304,12 @@ static int __init rcar_gen4_sysc_pd_init(void)
> const struct rcar_gen4_sysc_info *info;
> const struct of_device_id *match;
> struct rcar_gen4_pm_domains *domains;
> - struct device_node *np;
> void __iomem *base;
> unsigned int i;
> int error;
>
> - np = of_find_matching_node_and_match(NULL, rcar_gen4_sysc_matches, &match);
> + struct device_node *np __free(device_node) =
> + of_find_matching_node_and_match(NULL, rcar_gen4_sysc_matches, &match);
This breaks the declarations/blank-line/code structure, so please move
this up.
If you insist on keeping assignment to and validation of np together,
the line should be split in declaration and assignment.
> if (!np)
> return -ENODEV;
>
> @@ -369,14 +365,12 @@ static int __init rcar_gen4_sysc_pd_init(void)
> if (error) {
> pr_warn("Failed to add PM subdomain %s to parent %u\n",
> area->name, area->parent);
> - goto out_put;
> + return error;
> }
> }
>
> error = of_genpd_add_provider_onecell(np, &domains->onecell_data);
>
> -out_put:
> - of_node_put(np);
> return error;
return of_genpd_add_provider_onecell(...);
> }
> early_initcall(rcar_gen4_sysc_pd_init);
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Powered by blists - more mailing lists