[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8a13fd32-4bc4-4711-bf6b-7e0ce2e938ec@foss.st.com>
Date: Tue, 27 Aug 2024 10:07:10 +0200
From: Alexandre TORGUE <alexandre.torgue@...s.st.com>
To: Ahmad Fatoum <a.fatoum@...gutronix.de>,
Oleksij Rempel
<o.rempel@...gutronix.de>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Rob
Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor
Dooley <conor+dt@...nel.org>
CC: <devicetree@...r.kernel.org>, <netdev@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <kernel@...gutronix.de>,
<linux-stm32@...md-mailman.stormreply.com>,
<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v1] arm: dts: st: stm32mp151a-prtt1l: Fix QSPI
configuration
Hi
On 8/7/24 11:38, Ahmad Fatoum wrote:
> Hello Oleksij,
>
> On 06.08.24 14:05, Oleksij Rempel wrote:
>> Rename 'pins1' to 'pins' in the qspi_bk1_pins_a node to correct the
>> subnode name. The previous name caused the configuration to be
>> applied to the wrong subnode, resulting in QSPI not working properly.
>>
>> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
>> ---
>> arch/arm/boot/dts/st/stm32mp151a-prtt1l.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/st/stm32mp151a-prtt1l.dtsi b/arch/arm/boot/dts/st/stm32mp151a-prtt1l.dtsi
>> index 3938d357e198f..4db684478c320 100644
>> --- a/arch/arm/boot/dts/st/stm32mp151a-prtt1l.dtsi
>> +++ b/arch/arm/boot/dts/st/stm32mp151a-prtt1l.dtsi
>> @@ -123,7 +123,7 @@ flash@0 {
>> };
>>
>> &qspi_bk1_pins_a {
>> - pins1 {
>> + pins {
>
> As you have seen such device tree overriding is error prone and would
> be entirely avoidable if specifying full board-specific pinctrl groups
> was allowed for the stm32 platforms instead of override-and-pray.
You can create your own pin group in stm32mp15-pinctlr.dtsi. What is the
issue ? Do I miss something ? It will avoid to overwrite an existing
configuration
regards
alex
> Anyways, there's better syntax for such overriding now:
>
> &{qspi_blk1_pins_a/pins}
>
> which would cause a compilation error if pins was renamed again.
>
>> bias-pull-up;
>
> There's bias-disable in stm32mp15-pinctrl.dtsi. You may want to add
> a /delete-property/ for that to make sure, it's not up to the driver
> which one has priority.
>
>> drive-push-pull;
>> slew-rate = <1>;
>
> These are already in qspi_bk1_pins_a. If repeating those is ok, why
> not go a step further and just duplicate the pinmux property and stay
> clear of this issue altogether, provided Alex is amenable to changing
> his mind regarding pinctrl groups in board device trees.
>
>
> Cheers,
> Ahmad
>
Powered by blists - more mailing lists