linux-kernel - Re: [PATCH][next] wifi: radiotap: Avoid -Wflex-array-member-not-at-end warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ae3908c182664496784b1f1a86dd5bfd72fbc62.camel@sipsolutions.net>
Date: Tue, 27 Aug 2024 10:22:00 +0200
From: Johannes Berg <johannes@...solutions.net>
To: "Gustavo A. R. Silva" <gustavoars@...nel.org>, Kalle Valo
 <kvalo@...nel.org>,  Stanislav Yakovlev <stas.yakovlev@...il.com>, Ajay
 Singh <ajay.kathat@...rochip.com>, Claudiu Beznea
 <claudiu.beznea@...on.dev>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org, 
	libertas-dev@...ts.infradead.org, netdev@...r.kernel.org, 
	linux-hardening@...r.kernel.org
Subject: Re: [PATCH][next] wifi: radiotap: Avoid
 -Wflex-array-member-not-at-end warnings

On Tue, 2024-08-06 at 12:08 -0600, Gustavo A. R. Silva wrote:
> 
> +++ b/include/net/ieee80211_radiotap.h
> @@ -24,31 +24,36 @@
>   * struct ieee80211_radiotap_header - base radiotap header
>   */
>  struct ieee80211_radiotap_header {
> -	/**
> -	 * @it_version: radiotap version, always 0
> -	 */
> -	uint8_t it_version;
> -
> -	/**
> -	 * @it_pad: padding (or alignment)
> -	 */
> -	uint8_t it_pad;
> -
> -	/**
> -	 * @it_len: overall radiotap header length
> -	 */
> -	__le16 it_len;
> -
> -	/**
> -	 * @it_present: (first) present word
> -	 */
> -	__le32 it_present;
> +	/* New members MUST be added within the __struct_group() macro below. */

There cannot be new members without breaking interop with the radiotap
spec, that comment isn't really useful ;-)

> +	__struct_group(ieee80211_radiotap_header_hdr, hdr, __packed,

And also, "header header" sounds odd to me really. The header of the
header? What's what?

I think perhaps better to call this ieee80211_radiotap_hdr_fixed or so?

johannes