linux-kernel - Re: [PATCH v12 00/84] KVM: Stop grabbing references to PFNMAP'd pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <875xrme3nd.fsf@draig.linaro.org>
Date: Tue, 27 Aug 2024 10:06:14 +0100
From: Alex Bennée <alex.bennee@...aro.org>
To: Sean Christopherson <seanjc@...gle.com>
Cc: Paolo Bonzini <pbonzini@...hat.com>,  Marc Zyngier <maz@...nel.org>,
  Oliver Upton <oliver.upton@...ux.dev>,  Tianrui Zhao
 <zhaotianrui@...ngson.cn>,  Bibo Mao <maobibo@...ngson.cn>,  Huacai Chen
 <chenhuacai@...nel.org>,  Michael Ellerman <mpe@...erman.id.au>,  Anup
 Patel <anup@...infault.org>,  Paul Walmsley <paul.walmsley@...ive.com>,
  Palmer Dabbelt <palmer@...belt.com>,  Albert Ou <aou@...s.berkeley.edu>,
  Christian Borntraeger <borntraeger@...ux.ibm.com>,  Janosch Frank
 <frankja@...ux.ibm.com>,  Claudio Imbrenda <imbrenda@...ux.ibm.com>,
  kvm@...r.kernel.org,  linux-arm-kernel@...ts.infradead.org,
  kvmarm@...ts.linux.dev,  loongarch@...ts.linux.dev,
  linux-mips@...r.kernel.org,  linuxppc-dev@...ts.ozlabs.org,
  kvm-riscv@...ts.infradead.org,  linux-riscv@...ts.infradead.org,
  linux-kernel@...r.kernel.org,  David Matlack <dmatlack@...gle.com>,
  David Stevens <stevensd@...omium.org>
Subject: Re: [PATCH v12 00/84] KVM: Stop grabbing references to PFNMAP'd pages

Sean Christopherson <seanjc@...gle.com> writes:

> arm64 folks, the first two patches are bug fixes, but I have very low
> confidence that they are correct and/or desirable.  If they are more or
> less correct, I can post them separately if that'd make life easier.  I
> included them here to avoid conflicts, and because I'm pretty sure how
> KVM deals with MTE tags vs. dirty logging will impact what APIs KVM needs
> to provide to arch code.
>
> On to the series...  The TL;DR is that I would like to get input on two
> things:
>
>  1. Marking folios dirty/accessed only on the intial stage-2 page fault
>  2. The new APIs for faulting, prefetching, and doing "lookups" on
>  pfns

I've finally managed to get virtio-vulkan working on my Arm64 devbox
with an AMD graphics card plugged into the PCI. I'm confident that the
graphics path is using the discrete card memory (as it has been mapped
as device memory with alignment handlers to deal with the broken Altra
PCI). However aside from running graphics workloads in KVM guests is
their anything else I can check to see things are behaving as expected?

The predecessor series did break launching some KVM guests on my x86
system but with this series launching guests works fine and I haven't
noticed any weirdness.

So for those caveats you can certainly have a:

Tested-by: Alex Bennée <alex.bennee@...aro.org>

However if there is anything else I can do to further stress test this
code do let me know.

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro