linux-kernel - Re: [PATCH] staging: vme_user: added bound check to geoid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <473fe1f7-33c5-43ca-94c6-b874a1a60f59@stanley.mountain>
Date: Tue, 27 Aug 2024 12:40:08 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Riyan Dhiman <riyandhiman14@...il.com>
Cc: gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	linux-staging@...ts.linux.dev
Subject: Re: [PATCH] staging: vme_user: added bound check to geoid

You need to put v2 (v3 now) into the subject.

https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

On Tue, Aug 27, 2024 at 02:39:55PM +0530, Riyan Dhiman wrote:
> Added bound check for geoid in probe function because geoid will
> always be positive and less than VME_MAX_SLOT

Add a period to the end of the sentence.

But also add that "The geoid variable is a module parameter which lets people
hard code the slot number."  It's important to mention that it's a module
parameter so people know that it's root only.  Maybe mention that explicitly.
"The geoid variable is a module parameter so it can only be controlled by the
root user.  Only values between 0 and VME_MAX_SLOT make sense.  Invalid values
don't seem to cause a serious issue except for perhaps some weird error codes."

> 
> Signed-off-by: Riyan Dhiman <riyandhiman14@...il.com>
> ---
>  drivers/staging/vme_user/vme_fake.c   | 7 +++++++
>  drivers/staging/vme_user/vme_tsi148.c | 7 +++++++
>  2 files changed, 14 insertions(+)
> 
> diff --git a/drivers/staging/vme_user/vme_fake.c b/drivers/staging/vme_user/vme_fake.c
> index 7f84d1c86f29..d8f4ba29da0e 100644
> --- a/drivers/staging/vme_user/vme_fake.c
> +++ b/drivers/staging/vme_user/vme_fake.c
> @@ -1059,6 +1059,13 @@ static int __init fake_init(void)
>  	struct vme_slave_resource *slave_image;
>  	struct vme_lm_resource *lm;
>  
> +	/* If geoid provided, validate it is positive and less than VME_MAX_SLOTS */

This comment is obvoius.  Just leave it out.

regards,
dan carpener