linux-kernel - Re: [PATCH] efi/cper: Print correctable AER information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMj1kXFUDy3qSp5q3UxWkuSCLwJ3O3SaFN25f+9tojJL=sFNJQ@mail.gmail.com>
Date: Tue, 27 Aug 2024 12:23:27 +0200
From: Ard Biesheuvel <ardb@...nel.org>
To: Avadhut Naik <avadhut.naik@....com>
Cc: linux-efi@...r.kernel.org, linux-pci@...r.kernel.org, 
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org, bp@...en8.de, 
	james.morse@....com, tony.luck@...el.com, ilpo.jarvinen@...ux.intel.com, 
	ira.weiny@...el.com, yazen.ghannam@....com, avadnaik@....com
Subject: Re: [PATCH] efi/cper: Print correctable AER information

On Fri, 23 Aug 2024 at 02:24, Avadhut Naik <avadhut.naik@....com> wrote:
>
> From: Yazen Ghannam <yazen.ghannam@....com>
>
> Currently, cper_print_pcie() only logs Uncorrectable Error Status, Mask
> and Severity registers along with the TLP header.
>
> If a correctable error is received immediately preceding or following an
> Uncorrectable Fatal Error, its information is lost since Correctable
> Error Status and Mask registers are not logged.
>
> As such, to avoid skipping any possible error information, Correctable
> Error Status and Mask registers should also be logged.
>
> Additionally, ensure that AER information is also available through
> cper_print_pcie() for Correctable and Uncorrectable Non-Fatal Errors.
>
> Signed-off-by: Yazen Ghannam <yazen.ghannam@....com>
> Tested-by: Avadhut Naik <avadhut.naik@....com>
> Signed-off-by: Avadhut Naik <avadhut.naik@....com>
> ---
>  drivers/firmware/efi/cper.c | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
>

Queued for v6.12 - thanks.


> diff --git a/drivers/firmware/efi/cper.c b/drivers/firmware/efi/cper.c
> index 7d2cdd9e2227..b69e68ef3f02 100644
> --- a/drivers/firmware/efi/cper.c
> +++ b/drivers/firmware/efi/cper.c
> @@ -434,12 +434,17 @@ static void cper_print_pcie(const char *pfx, const struct cper_sec_pcie *pcie,
>         "%s""bridge: secondary_status: 0x%04x, control: 0x%04x\n",
>         pfx, pcie->bridge.secondary_status, pcie->bridge.control);
>
> -       /* Fatal errors call __ghes_panic() before AER handler prints this */
> -       if ((pcie->validation_bits & CPER_PCIE_VALID_AER_INFO) &&
> -           (gdata->error_severity & CPER_SEV_FATAL)) {
> +       /*
> +        * Print all valid AER info. Record may be from BERT (boot-time) or GHES (run-time).
> +        *
> +        * Fatal errors call __ghes_panic() before AER handler prints this.
> +        */
> +       if (pcie->validation_bits & CPER_PCIE_VALID_AER_INFO) {
>                 struct aer_capability_regs *aer;
>
>                 aer = (struct aer_capability_regs *)pcie->aer_info;
> +               printk("%saer_cor_status: 0x%08x, aer_cor_mask: 0x%08x\n",
> +                      pfx, aer->cor_status, aer->cor_mask);
>                 printk("%saer_uncor_status: 0x%08x, aer_uncor_mask: 0x%08x\n",
>                        pfx, aer->uncor_status, aer->uncor_mask);
>                 printk("%saer_uncor_severity: 0x%08x\n",
>
> base-commit: fdf969bbceb389f5a7c69e226daf2cb724ea66ba
> --
> 2.34.1
>