[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240827120953.00005450@Huawei.com>
Date: Tue, 27 Aug 2024 12:09:53 +0100
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Yangtao Li <frank.li@...o.com>
CC: <clement.leger@...tlin.com>, <andrew@...n.ch>, <f.fainelli@...il.com>,
<olteanv@...il.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
<kuba@...nel.org>, <pabeni@...hat.com>, <ulli.kroll@...glemail.com>,
<linus.walleij@...aro.org>, <marcin.s.wojtas@...il.com>,
<linux@...linux.org.uk>, <alexandre.torgue@...s.st.com>,
<joabreu@...opsys.com>, <mcoquelin.stm32@...il.com>, <hkallweit1@...il.com>,
<u.kleine-koenig@...gutronix.de>, <jacob.e.keller@...el.com>,
<justinstitt@...gle.com>, <sd@...asysnail.net>, <horms@...nel.org>,
<linux-renesas-soc@...r.kernel.org>, <netdev@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
<linux-stm32@...md-mailman.stormreply.com>, Maxime Chevallier
<maxime.chevallier@...tlin.com>, Christophe JAILLET
<christophe.jaillet@...adoo.fr>
Subject: Re: [net-next v3 8/9] net: mvpp2: Convert to devm_clk_get_enabled()
and devm_clk_get_optional_enabled()
On Tue, 27 Aug 2024 03:57:11 -0600
Yangtao Li <frank.li@...o.com> wrote:
> Use devm_clk_get_enabled() and devm_clk_get_optional_enabled()
> to simplify code.
>
> Signed-off-by: Yangtao Li <frank.li@...o.com>
> Reviewed-by: Maxime Chevallier <maxime.chevallier@...tlin.com>
> Tested-by: Maxime Chevallier <maxime.chevallier@...tlin.com>
> Suggested-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> Reviewed-by: Marcin Wojtas <marcin.s.wojtas@...il.com>
>
> @@ -7745,12 +7710,6 @@ static void mvpp2_remove(struct platform_device *pdev)
>
> if (!dev_of_node(&pdev->dev))
> return;
Given this makes no difference any more, drop the above dev_of_node() check.
> -
> - clk_disable_unprepare(priv->axi_clk);
> - clk_disable_unprepare(priv->mg_core_clk);
> - clk_disable_unprepare(priv->mg_clk);
> - clk_disable_unprepare(priv->pp_clk);
> - clk_disable_unprepare(priv->gop_clk);
> }
>
> static const struct of_device_id mvpp2_match[] = {
Powered by blists - more mailing lists