linux-kernel - RE: [PATCH] Input: keypad-nomadik-ske

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PH0PR03MB651239F36ABA828A79579D1C8E942@PH0PR03MB6512.namprd03.prod.outlook.com>
Date: Tue, 27 Aug 2024 09:52:16 +0000
From: "Hennerich, Michael" <Michael.Hennerich@...log.com>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Arnd Bergmann
	<arnd@...db.de>,
        Nuno Sá <noname.nuno@...il.com>
CC: Linus Walleij <linus.walleij@...aro.org>,
        "linux-input@...r.kernel.org"
	<linux-input@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        Lee Jones <lee@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>,
        "Agarwal, Utsav"
	<Utsav.Agarwal@...log.com>
Subject: RE: [PATCH] Input: keypad-nomadik-ske - remove the driver



> -----Original Message-----
> From: Dmitry Torokhov <dmitry.torokhov@...il.com>
> Sent: Monday, August 19, 2024 4:55 PM
> To: Arnd Bergmann <arnd@...db.de>; Nuno Sá <noname.nuno@...il.com>;
> Hennerich, Michael <Michael.Hennerich@...log.com>
> Cc: Linus Walleij <linus.walleij@...aro.org>; linux-input@...r.kernel.org; linux-
> kernel@...r.kernel.org; Lee Jones <lee@...nel.org>; linux-arm-
> kernel@...ts.infradead.org; Agarwal, Utsav <Utsav.Agarwal@...log.com>
> Subject: Re: [PATCH] Input: keypad-nomadik-ske - remove the driver
> 
> On Mon, Aug 19, 2024 at 11:29:32AM +0200, Arnd Bergmann wrote:
> > On Fri, Aug 16, 2024, at 20:54, Dmitry Torokhov wrote:
> > > The users of this driver were removed in 2013 in commit 28633c54bda6
> > > ("ARM: ux500: Rip out keypad initialisation which is no longer used").
> > >
> > > Remove the driver as well.
> > >
> > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> > > ---
> > >  drivers/input/keyboard/Kconfig                |  11 -
> > >  drivers/input/keyboard/Makefile               |   1 -
> > >  drivers/input/keyboard/nomadik-ske-keypad.c   | 378 ------------------
> > >  .../linux/platform_data/keypad-nomadik-ske.h  |  50 ---
> > >  4 files changed, 440 deletions(-)
> > >
> >
> > Acked-by: Arnd Bergmann <arnd@...db.de>
> >
> > I have a list of drivers that I determined to be likely unused as well
> > and found a few more input drivers that were unused in 2022:
> >
> > CONFIG_KEYBOARD_ADP5520/CONFIG_PMIC_ADP5520
> > CONFIG_KEYBOARD_ADP5589
> > CONFIG_INPUT_AD714X
> > CONFIG_TOUCHSCREEN_AD7877
> >
> > As far as I can tell, these all lost their last device definition, or
> > they never had one and are impossible to be used with device tree
> > data.
> 
> I asked Analog Devices folks (CCed) about 5589 and Nuno said that it is still
> relevant and promised to do conversion to DT similar to adp5588.
> 
> Nuno, Michale, what about the other drivers that Arnd listed?

We'll provide dt conversion patches for AD7877 and AD714x as well.

Regards,
Michael

> 
> Thanks.
> 
> --
> Dmitry