[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240827121955.GB1607@lst.de>
Date: Tue, 27 Aug 2024 14:19:55 +0200
From: Christoph Hellwig <hch@....de>
To: Puranjay Mohan <pjy@...zon.com>
Cc: Keith Busch <kbusch@...nel.org>, Jens Axboe <axboe@...nel.dk>,
Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>,
linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org,
puranjay@...nel.org
Subject: Re: [PATCH] nvme: check if the namespace supports metadata in
nvme_map_user_request()
On Tue, Aug 27, 2024 at 12:17:01PM +0000, Puranjay Mohan wrote:
> + if (meta_buffer && meta_len && bdev && !blk_get_integrity(bdev->bd_disk))
> + return -EINVAL;
Overly long line here. If we go past my initial RFC I'd probably
restructure the function a little bit, i.e. add a new
bool has_metadata = bdev && meta_buffer && meta_len;
and then use that both for the support check and the actualy mapping
below.
Powered by blists - more mailing lists