linux-kernel - Re: [PATCH] kernel/ext4: nested locking for xattr inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <172476284023.635532.2188826848588011043.b4-ty@mit.edu>
Date: Tue, 27 Aug 2024 08:47:34 -0400
From: "Theodore Ts'o" <tytso@....edu>
To: adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Wojciech Gładysz <wojciech.gladysz@...ogain.com>
Cc: "Theodore Ts'o" <tytso@....edu>
Subject: Re: [PATCH] kernel/ext4: nested locking for xattr inode


On Thu, 01 Aug 2024 16:38:27 +0200, Wojciech Gładysz wrote:
> Add nested locking with I_MUTEX_XATTR subclass to avoid lockdep warning
> while handling xattr inode on file open syscall at ext4_xattr_inode_iget.
> 
> Backtrace
> EXT4-fs (loop0): Ignoring removed oldalloc option
> ======================================================
> WARNING: possible circular locking dependency detected
> 5.10.0-syzkaller #0 Not tainted
> ------------------------------------------------------
> syz-executor543/2794 is trying to acquire lock:
> ffff8880215e1a48 (&ea_inode->i_rwsem#7/1){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:782 [inline]
> ffff8880215e1a48 (&ea_inode->i_rwsem#7/1){+.+.}-{3:3}, at: ext4_xattr_inode_iget+0x42a/0x5c0 fs/ext4/xattr.c:425
> 
> [...]

Applied, thanks!

[1/1] kernel/ext4: nested locking for xattr inode
      commit: d1bc560e9a9c78d0b2314692847fc8661e0aeb99

Best regards,
-- 
Theodore Ts'o <tytso@....edu>