linux-kernel - Re: [PATCH] selftests/vDSO: support DT_GNU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f9e2d443-9d20-498a-a2d7-fa2e13fbb3f9@linuxfoundation.org>
Date: Tue, 27 Aug 2024 07:12:35 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Xi Ruoyao <xry111@...111.site>, Fangrui Song <maskray@...gle.com>,
 Shuah Khan <shuah@...nel.org>, linux-kselftest@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] selftests/vDSO: support DT_GNU_HASH

On 8/26/24 00:07, Xi Ruoyao wrote:
> On Wed, 2024-08-14 at 20:26 -0700, Fangrui Song wrote:
>> glibc added support for DT_GNU_HASH in 2006 and DT_HASH has been
>> obsoleted for more than one decade in many Linux distributions.
>>
>> Many vDSOs support DT_GNU_HASH. This patch adds selftests support.
>>
>> Signed-off-by: Fangrui Song <maskray@...gle.com>
>> ---
> 
> Ping.
> 
> Some context: I'd change LoongArch vDSO to use the toolchain default
> instead of forcing DT_HASH (note that LoongArch is launched decades
> after all major distros switched to DT_GNU_HASH), but without the
> selftest support we'll lose test coverage.
> 
> And now ARM64 has already lost test coverage after commit 48f6430505c0.
> 

I am seeing several checkpatch errors - please fix them and send me v2.

thanks,
-- Shuah