| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <Zs6R6pqpFybPDa31@dragon>
Date: Wed, 28 Aug 2024 10:56:42 +0800
From: Shawn Guo <shawnguo2@...h.net>
To: Frieder Schrempf <frieder@...s.de>
Cc: Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
imx@...ts.linux.dev, Krzysztof Kozlowski <krzk+dt@...nel.org>,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
Rob Herring <robh@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Shawn Guo <shawnguo@...nel.org>,
Frieder Schrempf <frieder.schrempf@...tron.de>,
Alexander Stein <alexander.stein@...tq-group.com>,
Fabio Estevam <festevam@...il.com>,
Francesco Dolcini <francesco.dolcini@...adex.com>,
Gregor Herburger <gregor.herburger@...tq-group.com>,
Hugo Villeneuve <hvilleneuve@...onoff.com>,
Joao Paulo Goncalves <joao.goncalves@...adex.com>,
Mathieu Othacehe <m.othacehe@...il.com>,
Parthiban Nallathambi <parthiban@...umiz.com>,
Pengutronix Kernel Team <kernel@...gutronix.de>
Subject: Re: [PATCH 4/4] arm64: dts: imx8mm-kontron: Add DL (Display-Line)
overlay with LVDS support
On Tue, Aug 06, 2024 at 03:33:02PM +0200, Frieder Schrempf wrote:
> From: Frieder Schrempf <frieder.schrempf@...tron.de>
>
> The Kontron Electronics DL i.MX8MM consists of the BL i.MX8MM board
> and a 7" LVDS panel. Provide an overlay that enables the panel.
>
> Signed-off-by: Frieder Schrempf <frieder.schrempf@...tron.de>
> ---
> Note: This currently throws the following warnings:
>
> Warning (graph_port): /fragment@3: graph port node name should be 'port'
> Warning (graph_endpoint): /fragment@..._overlay__: graph endpoint node name should be 'endpoint'
> Warning (graph_endpoint): /fragment@..._overlay__: graph connection to node '/fragment@..._overlay__/ports/port@...ndpoint' is not bidirectional
>
> There is the following commit in DTC that relaxes these checks and
> will eventually resolve these warnings:
>
> 84b056a89d ("checks: relax graph checks for overlays")
>
> https://git.kernel.org/pub/scm/utils/dtc/dtc.git/commit/?id=84b056a89d3c5b6cf6c5eeeafd4c4b14d6333aa9
> ---
> arch/arm64/boot/dts/freescale/Makefile | 4 +
> .../boot/dts/freescale/imx8mm-kontron-dl.dtso | 210 ++++++++++++++++++
> 2 files changed, 214 insertions(+)
> create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-kontron-dl.dtso
>
> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> index f04c22b7de72e..d8af069139920 100644
> --- a/arch/arm64/boot/dts/freescale/Makefile
> +++ b/arch/arm64/boot/dts/freescale/Makefile
> @@ -244,6 +244,10 @@ dtb-$(CONFIG_ARCH_MXC) += imx93-tqma9352-mba93xxla.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx93-var-som-symphony.dtb
> dtb-$(CONFIG_ARCH_MXC) += imx95-19x19-evk.dtb
>
> +imx8mm-kontron-dl-dtbs := imx8mm-kontron-bl.dtb imx8mm-kontron-dl.dtbo
> +
> +dtb-$(CONFIG_ARCH_MXC) += imx8mm-kontron-dl.dtb
> +
> imx8mm-venice-gw72xx-0x-imx219-dtbs := imx8mm-venice-gw72xx-0x.dtb imx8mm-venice-gw72xx-0x-imx219.dtbo
> imx8mm-venice-gw72xx-0x-rpidsi-dtbs := imx8mm-venice-gw72xx-0x.dtb imx8mm-venice-gw72xx-0x-rpidsi.dtbo
> imx8mm-venice-gw72xx-0x-rs232-rts-dtbs := imx8mm-venice-gw72xx-0x.dtb imx8mm-venice-gw72xx-0x-rs232-rts.dtbo
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-dl.dtso b/arch/arm64/boot/dts/freescale/imx8mm-kontron-dl.dtso
> new file mode 100644
> index 0000000000000..b2d593d700e2d
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-dl.dtso
> @@ -0,0 +1,210 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (C) 2023 Kontron Electronics GmbH
2024?
> + */
> +
> +/dts-v1/;
> +/plugin/;
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include "imx8mm-pinfunc.h"
> +
> +&{/} {
> + compatible = "kontron,imx8mm-bl", "kontron,imx8mm-sl", "fsl,imx8mm";
Not sure we need compatible in overlay.
> +
> + backlight: backlight {
> + compatible = "pwm-backlight";
> + pwms = <&pwm1 0 50000 0>;
> + brightness-levels = <0 100>;
> + num-interpolated-steps = <100>;
> + default-brightness-level = <100>;
> + };
> +
> + panel {
> + compatible = "jenson,bl-jt60050-01a", "panel-lvds";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_panel>;
> + backlight = <&backlight>;
> + data-mapping = "vesa-24";
> + enable-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>;
> + height-mm = <86>;
> + width-mm = <154>;
> +
> + panel-timing {
> + clock-frequency = <51200000>;
> + hactive = <1024>;
> + vactive = <600>;
> + hsync-len = <1>;
> + hfront-porch = <160>;
> + hback-porch = <160>;
> + vsync-len = <1>;
> + vfront-porch = <12>;
> + vback-porch = <23>;
> + };
> +
> + port {
> + panel_out_bridge: endpoint {
> + remote-endpoint = <&bridge_out_panel>;
> + };
> + };
> + };
> +};
> +
> +&dsi_mux_sel_hdmi {
> + status = "disabled";
> +};
> +
> +&dsi_mux_sel_lvds {
> + status = "okay";
> +};
> +
> +&dsi_out_bridge {
> + remote-endpoint = <&bridge_in_dsi_lvds>;
> +};
> +
> +&gpio3 {
> + panel-rst-hog {
> + gpio-hog;
> + gpios = <20 GPIO_ACTIVE_HIGH>;
> + output-high;
> + line-name = "panel-reset";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_panel_rst>;
Are you sure the pinctrl in the gpio-hog node works? Grouping these
pins as pinctrl_gpio3 in parent node (like you did in patch #3) might be
a good idea.
> + };
> +
> + panel-stby-hog {
> + gpio-hog;
> + gpios = <21 GPIO_ACTIVE_HIGH>;
> + output-high;
> + line-name = "panel-standby";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_panel_stby>;
> + };
> +
> + panel-hinv-hog {
> + gpio-hog;
> + gpios = <24 GPIO_ACTIVE_HIGH>;
> + output-high;
> + line-name = "panel-horizontal-invert";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_panel_hinv>;
> + };
> +
> + panel-vinv-hog {
> + gpio-hog;
> + gpios = <25 GPIO_ACTIVE_HIGH>;
> + output-low;
> + line-name = "panel-vertical-invert";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_panel_vinv>;
> + };
> +};
> +
> +&hdmi {
> + status = "disabled";
> +};
> +
> +&i2c2 {
> + clock-frequency = <400000>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_i2c2>;
> + status = "okay";
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
Can we move these two into property list above which ends with 'status'?
> +
> + gt911@5d {
Can we use a generic name for the device node?
Shawn
> + compatible = "goodix,gt928";
> + reg = <0x5d>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_touch>;
> + interrupt-parent = <&gpio3>;
> + interrupts = <22 8>;
> + reset-gpios = <&gpio3 23 0>;
> + irq-gpios = <&gpio3 22 0>;
> + };
> +};
> +
> +&lvds {
> + status = "okay";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> +
> + bridge_in_dsi_lvds: endpoint {
> + remote-endpoint = <&dsi_out_bridge>;
> + data-lanes = <1 2>;
> + };
> + };
> +
> + port@2 {
> + reg = <2>;
> +
> + bridge_out_panel: endpoint {
> + remote-endpoint = <&panel_out_bridge>;
> + };
> + };
> + };
> +};
> +
> +&pwm1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_pwm1>;
> + status = "okay";
> +};
> +
> +&iomuxc {
> + pinctrl_i2c2: i2c2grp {
> + fsl,pins = <
> + MX8MM_IOMUXC_I2C2_SCL_I2C2_SCL 0x40000083
> + MX8MM_IOMUXC_I2C2_SDA_I2C2_SDA 0x40000083
> + >;
> + };
> +
> + pinctrl_panel: panelgrp {
> + fsl,pins = <
> + MX8MM_IOMUXC_SAI5_RXFS_GPIO3_IO19 0x19
> + >;
> + };
> +
> + pinctrl_panel_hinv: panelhinvgrp {
> + fsl,pins = <
> + MX8MM_IOMUXC_SAI5_RXD3_GPIO3_IO24 0x19
> + >;
> + };
> +
> + pinctrl_panel_rst: panelrstgrp {
> + fsl,pins = <
> + MX8MM_IOMUXC_SAI5_RXC_GPIO3_IO20 0x19
> + >;
> + };
> +
> + pinctrl_panel_stby: panelstbygrp {
> + fsl,pins = <
> + MX8MM_IOMUXC_SAI5_RXD0_GPIO3_IO21 0x19
> + >;
> + };
> +
> + pinctrl_panel_vinv: panelvinvgrp {
> + fsl,pins = <
> + MX8MM_IOMUXC_SAI5_MCLK_GPIO3_IO25 0x19
> + >;
> + };
> +
> + pinctrl_pwm1: pwm1grp {
> + fsl,pins = <
> + MX8MM_IOMUXC_SPDIF_EXT_CLK_PWM1_OUT 0x6
> + >;
> + };
> +
> + pinctrl_touch: touchgrp {
> + fsl,pins = <
> + MX8MM_IOMUXC_SAI5_RXD1_GPIO3_IO22 0x19
> + MX8MM_IOMUXC_SAI5_RXD2_GPIO3_IO23 0x19
> + >;
> + };
> +};
> --
> 2.45.2
>
Powered by blists - more mailing lists