linux-kernel - Re: [PATCH v1] cirrus: Simplify with dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9b5a3025-3e78-44b9-98f5-c945a6ac48d7@opensource.cirrus.com>
Date: Wed, 28 Aug 2024 15:59:50 +0100
From: Richard Fitzgerald <rf@...nsource.cirrus.com>
To: Thomas Gleixner <tglx@...utronix.de>,
        Charles Keepax
	<ckeepax@...nsource.cirrus.com>,
        Yan Zhen <yanzhen@...o.com>
CC: <linus.walleij@...aro.org>, <linux-sound@...r.kernel.org>,
        <patches@...nsource.cirrus.com>, <linux-kernel@...r.kernel.org>,
        <linux-gpio@...r.kernel.org>, <opensource.kernel@...o.com>
Subject: Re: [PATCH v1] cirrus: Simplify with dev_err_probe()

On 28/08/2024 15:47, Thomas Gleixner wrote:
> On Wed, Aug 28 2024 at 13:27, Charles Keepax wrote:
>> On Wed, Aug 28, 2024 at 08:01:18PM +0800, Yan Zhen wrote:
>>> @@ -1064,10 +1064,9 @@ static int madera_pin_probe(struct platform_device *pdev)
>>>   		ret = pinctrl_register_mappings(pdata->gpio_configs,
>>>   						pdata->n_gpio_configs);
>>>   		if (ret) {
>>> -			dev_err(priv->dev,
>>> -				"Failed to register pdata mappings (%d)\n",
>>> -				ret);
>>> -			return ret;
>>> +			return dev_err_probe(priv->dev, ret,
>>> +						"Failed to register pdata mappings (%d)\n",
>>> +						ret);
>>>   		}
>>
>> Since we are doing a respin anyway also the brackets on the if
>> should be dropped on both of these as well.
> 
> No. https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#bracket-rules
> 

https://www.kernel.org/doc/html/latest/process/coding-style.html#codingstyle

does not say that. It says:

"Do not unnecessarily use braces where a single statement will do."

Note: single statement, not single line.

coding-style.rst is the coding style. If you disagree with the coding
style, send a patch to change coding-style.rst.

> Thanks,
> 
>          tglx