linux-kernel - Re: [PATCH] of/platform: Use dev_is_platform() to identify PCI devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240828150826.GA3803566-robh@kernel.org>
Date: Wed, 28 Aug 2024 10:08:26 -0500
From: Rob Herring <robh@...nel.org>
To: Kunwu Chan <kunwu.chan@...ux.dev>
Cc: saravanak@...gle.com, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, Kunwu Chan <chentao@...inos.cn>
Subject: Re: [PATCH] of/platform: Use dev_is_platform() to identify PCI
 devices

On Tue, Aug 27, 2024 at 05:44:02PM +0800, Kunwu Chan wrote:
> From: Kunwu Chan <chentao@...inos.cn>

Subject - For PCI devices?

> 
> Use dev_is_platform() instead of checking bus type directly.
> 
> Signed-off-by: Kunwu Chan <chentao@...inos.cn>
> ---
>  drivers/of/platform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/of/platform.c b/drivers/of/platform.c
> index 86be4dfb9323..3696140bae9e 100644
> --- a/drivers/of/platform.c
> +++ b/drivers/of/platform.c
> @@ -625,7 +625,7 @@ int of_platform_device_destroy(struct device *dev, void *data)
>  	of_node_clear_flag(dev->of_node, OF_POPULATED);
>  	of_node_clear_flag(dev->of_node, OF_POPULATED_BUS);
>  
> -	if (dev->bus == &platform_bus_type)
> +	if (dev_is_platform(dev))
>  		platform_device_unregister(to_platform_device(dev));
>  #ifdef CONFIG_ARM_AMBA
>  	else if (dev->bus == &amba_bustype)

Perhaps to keep things consistent, add a dev_is_amba() and use it here.

> -- 
> 2.41.0
>