linux-kernel - Re: [PATCH] drm/tegra: hub: Use fn parameter directly to fix Coccinelle warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ddh6votnreuhbylvk5wsiclep5e6qkcrdf66h3fvhsgsampwqk@w4a3p6n325jn>
Date: Wed, 28 Aug 2024 17:10:55 +0200
From: Thierry Reding <thierry.reding@...il.com>
To: Thorsten Blum <thorsten.blum@...lux.com>
Cc: mperttunen@...dia.com, airlied@...il.com, daniel@...ll.ch, 
	jonathanh@...dia.com, dri-devel@...ts.freedesktop.org, linux-tegra@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/tegra: hub: Use fn parameter directly to fix
 Coccinelle warning

On Wed, Jul 10, 2024 at 11:00:35PM GMT, Thorsten Blum wrote:
> The function parameter out can be used directly instead of assigning it
> to a temporary u64 variable first.
> 
> Remove the local variable tmp2 and use the parameter out directly as the
> divisor in do_div() to remove the following Coccinelle/coccicheck
> warning reported by do_div.cocci:
> 
>   WARNING: do_div() does a 64-by-32 division, please consider using div64_u64 instead
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...lux.com>
> ---
>  drivers/gpu/drm/tegra/hub.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)

Applied, thanks.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)