linux-kernel - Re: [PATCH 0/9] mmc: convert to devm_clk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDyKFrN9L+u_X7Ur+j--i-tewd31EXzwCojOP+Sxuyxpk4Phg@mail.gmail.com>
Date: Wed, 28 Aug 2024 17:11:08 +0200
From: Ulf Hansson <ulf.hansson@...aro.org>
To: zhangxirui <xirui.zhang@...o.com>
Cc: Robert Richter <rric@...nel.org>, Jaehoon Chung <jh80.chung@...sung.com>, 
	Nicolas Pitre <nico@...xnic.net>, Shawn Guo <shawnguo@...nel.org>, 
	Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>, 
	Fabio Estevam <festevam@...il.com>, Adrian Hunter <adrian.hunter@...el.com>, 
	Taichi Sugaya <sugaya.taichi@...ionext.com>, Takao Orito <orito.takao@...ionext.com>, 
	Michal Simek <michal.simek@....com>, Linus Walleij <linus.walleij@...aro.org>, 
	Bastien Curutchet <bastien.curutchet@...tlin.com>, 
	Uwe Kleine-König <u.kleine-koenig@...gutronix.de>, 
	linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org, imx@...ts.linux.dev, 
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 0/9] mmc: convert to devm_clk_get_enabled() API

On Tue, 27 Aug 2024 at 09:34, zhangxirui <xirui.zhang@...o.com> wrote:
>
> This series use devm_clk_get_enabled() to simplify code
> and avoids the calls to clk_disable_unprepare()

I agree that it simplifies code - but it also changes the behaviour,
in which order clocks are getting unprepared/disabled during the
->remove() phase. In other words, this needs to be thoroughly tested
and not just considered as a trivial cleanup series.

For example, if there is a PM domain attached to the mmc host device,
is it really okay to allow powering-off the PM domain before the
clocks are being gated? This could potentially happen if we apply the
$subject series.

Kind regards
Uffe

>
> zhangxirui (9):
>   mmc: cavium-thunderx: Use devm_clk_get_enabled() helpers
>   mmc: davinci_mmc: Use devm_clk_get_enabled() helpers
>   mmc: dw_mmc-hi3798cv200: Use devm_clk_get_enabled() helpers
>   mmc: mvsdio: Use devm_clk_get_enabled() helpers
>   mmc: mxcmmc: Use devm_clk_get_enabled() helpers
>   mmc: mxs-mmc: Use devm_clk_get_enabled() helpers
>   mmc: sdhci: milbeaut: Use devm_clk_get_enabled() helpers
>   mmc: sdhci-of-arasan: Use devm_clk_get_enabled() helpers
>   mmc: sdhci_f_sdh30: Use devm_clk_get_enabled() helpers
>
>  drivers/mmc/host/cavium-thunderx.c    |  7 +-----
>  drivers/mmc/host/davinci_mmc.c        |  8 +-----
>  drivers/mmc/host/dw_mmc-hi3798cv200.c | 28 +++------------------
>  drivers/mmc/host/mvsdio.c             | 13 +++-------
>  drivers/mmc/host/mxcmmc.c             | 25 +++----------------
>  drivers/mmc/host/mxs-mmc.c            | 13 +++-------
>  drivers/mmc/host/sdhci-milbeaut.c     | 25 +++----------------
>  drivers/mmc/host/sdhci-of-arasan.c    | 31 ++++-------------------
>  drivers/mmc/host/sdhci_f_sdh30.c      | 36 ++++++++-------------------
>  9 files changed, 35 insertions(+), 151 deletions(-)
>
> --
> 2.25.1
>