[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4ce943f8-9557-4563-a107-acb78a0b33f5@gmx.de>
Date: Wed, 28 Aug 2024 20:08:55 +0200
From: Helge Deller <deller@....de>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
linux-omap@...r.kernel.org, linux-fbdev@...r.kernel.org,
dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] fbdev: omapfb: panel-sony-acx565akm: Simplify
show_cabc_available_modes()
On 8/8/24 11:46, Christophe JAILLET wrote:
> Use sysfs_emit_at() instead of snprintf() + custom logic.
> Using sysfs_emit_at() is much more simple.
>
> Also, sysfs_emit() is already used in this function, so using
> sysfs_emit_at() is more consistent.
>
> Also simplify the logic:
> - always add a space after an entry
> - change the last space into a '\n'
>
> Finally it is easy to see that, given the size of cabc_modes, PAGE_SIZE
> can not be reached.
> So better keep everything simple (and correct).
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
applied.
Thanks!
Helge
Powered by blists - more mailing lists