linux-kernel - Re: [PATCH v1] cirrus: Simplify with dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ttf4bjov.ffs@tglx>
Date: Wed, 28 Aug 2024 20:12:32 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Richard Fitzgerald <rf@...nsource.cirrus.com>, Charles Keepax
 <ckeepax@...nsource.cirrus.com>, Yan Zhen <yanzhen@...o.com>
Cc: linus.walleij@...aro.org, linux-sound@...r.kernel.org,
 patches@...nsource.cirrus.com, linux-kernel@...r.kernel.org,
 linux-gpio@...r.kernel.org, opensource.kernel@...o.com
Subject: Re: [PATCH v1] cirrus: Simplify with dev_err_probe()

On Wed, Aug 28 2024 at 15:59, Richard Fitzgerald wrote:
> On 28/08/2024 15:47, Thomas Gleixner wrote:
>> On Wed, Aug 28 2024 at 13:27, Charles Keepax wrote:
>>> Since we are doing a respin anyway also the brackets on the if
>>> should be dropped on both of these as well.
>> 
>> No. https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#bracket-rules
>
> https://www.kernel.org/doc/html/latest/process/coding-style.html#codingstyle
>
> does not say that. It says:
>
> "Do not unnecessarily use braces where a single statement will do."
>
> Note: single statement, not single line.
>
> coding-style.rst is the coding style. If you disagree with the coding
> style, send a patch to change coding-style.rst.

There will never be an agreement about this, but for code which I
maintain and goes through the tip tree, the single line rule applies
simply because it's my time wasted when I can't parse code fluently.

Thanks,

        tglx