linux-kernel - Re: [PATCH v1 1/1] clk: devres: Simplify devres handling functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <def27b96be1c2a8b84f83a55e310bf95.sboyd@kernel.org>
Date: Wed, 28 Aug 2024 11:39:51 -0700
From: Stephen Boyd <sboyd@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org, Michael Turquette <mturquette@...libre.com>, Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Subject: Re: [PATCH v1 1/1] clk: devres: Simplify devres handling functions

Quoting Andy Shevchenko (2024-08-28 06:08:20)
> On Tue, Aug 27, 2024 at 05:19:04PM -0700, Stephen Boyd wrote:
> > Quoting Andy Shevchenko (2024-08-22 08:58:22)
> 
> ...
> 
> > > -       state = devres_alloc(devm_clk_release, sizeof(*state), GFP_KERNEL);
> > > +       state = devm_kmalloc(dev, sizeof(*state), GFP_KERNEL);
> > 
> > When is this allocation freed if the get() fails? When the calling
> > device driver detaches?
> 
> At device unbinding. Is it a problem?

It is a change, and the commit text said no functional change :(